Update params directrly in PasswordStrengthValidateEvent

escopecz · Oct 27, 2023 · 2cf70cb · 2cf70cb
1 parent 783d6bc
commit 2cf70cb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 27 deletions.
diff --git a/app/bundles/UserBundle/Event/PasswordStrengthValidateEvent.php b/app/bundles/UserBundle/Event/PasswordStrengthValidateEvent.php
@@ -9,32 +9,8 @@
 class PasswordStrengthValidateEvent extends Event
 {
     public function __construct(
-        private bool $isValid,
-        private string $password
+        public bool $isValid,
+        public string $password
     ) {
     }
-
-    public function isValid(): bool
-    {
-        return $this->isValid;
-    }
-
-    public function setIsValid(bool $isValid): PasswordStrengthValidateEvent
-    {
-        $this->isValid = $isValid;
-
-        return $this;
-    }
-
-    public function getPassword(): string
-    {
-        return $this->password;
-    }
-
-    public function setPassword(string $password): PasswordStrengthValidateEvent
-    {
-        $this->password = $password;
-
-        return $this;
-    }
 }
diff --git a/app/bundles/UserBundle/Model/PasswordStrengthEstimatorModel.php b/app/bundles/UserBundle/Model/PasswordStrengthEstimatorModel.php
@@ -39,7 +39,7 @@ public function validate(?string $password, int $score = self::MINIMUM_PASSWORD_
         $passwordStrengthValidateEvent = new PasswordStrengthValidateEvent($isValid, $password);
         $this->dispatcher->dispatch($passwordStrengthValidateEvent, UserEvents::USER_PASSWORD_STRENGTH_VALIDATION);
 
-        return $passwordStrengthValidateEvent->isValid();
+        return $passwordStrengthValidateEvent->isValid;
     }
 
     /**