Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semantic-release? #236

Open
voxpelli opened this issue Sep 18, 2024 · 1 comment
Open

Update semantic-release? #236

voxpelli opened this issue Sep 18, 2024 · 1 comment

Comments

@voxpelli
Copy link
Member

I noticed that we have pinned semantic-release to 19 in this repo:

semantic_version: 19

But the latest version is 24.1.1 at the time I create this issue.

Since the semantic-release version is neither defined through the uses: of the workflow or in devDependencies, we will get no update suggestions from Dependabot.

We should probably add it to devDependencies and skip the third party action in favor of the current suggested setup.

Either that or mimic eslint-community/eslint-plugin-promise#508 / eslint-community/eslint-plugin-promise#506 and switch to release-please.

Thoughts @MichaelDeBoey?

@MichaelDeBoey
Copy link
Member

I would be in favor of simplifying the setup + use latest semantic-release

Switching towards release-please seems a bit unnecessary as semantic-release should support feat!:, but I wouldn't mind having it consistent either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants