-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abnormal module resolution for github:
dependencies
#956
Comments
the dev branch works fine: https://next.esm.sh/gh/TurbowarpESM/scratch-svg-renderer@79d8743553 |
more example: https://esm.sh/gh/TurbowarpESM/scratch-render Is it caused by cache? I feel confused. |
it's not deployed to the main yet |
Thank you so much for still replying my weird technical issues. There's an exception when I try to import the library The issue of the previously mentioned libraries ( |
Steps to reproduce
A
) and upload it to GitHub.B
) and upload it to GitHub.package.json
ofB
, specifyA
as a dependency viagithub:UserName/A.git
.esm.sh
to loadB
.Expected behavior
Things works just fine.
Actual behavior
The behavior here is a little funny.
If there is a same npm package named
A
onregistry.npmjs.org
: The resolver uses the one onregistry.npmjs.org
.If there is no same npm package named
A
onregistry.npmjs.org
: The resolver silently fails.This may lead to dependency pollution attack.
The text was updated successfully, but these errors were encountered: