Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Time Zone awareness to Date Range Facet Filter #443

Closed
DiegoPino opened this issue Apr 22, 2024 · 2 comments
Closed

Add Time Zone awareness to Date Range Facet Filter #443

DiegoPino opened this issue Apr 22, 2024 · 2 comments
Labels
enhancement New feature or request Search and Discovery Mess around and find out Search API Sub Modules When you need more .info.yml files to keep life organized
Milestone

Comments

@DiegoPino
Copy link
Member

What?

Because of time zone (Solr indexed days) v/s User facing date processing ranges might end not being inclusive and either removing results or not matching at all.

The solution is to add some "slack" to any range passed to make the range inclusive. Slack means basically adding 23:59:59 to the end and to the beginning to cover more ground (one option, other is to read the actual Time Zone from the server and use that)

@DiegoPino DiegoPino added enhancement New feature or request Search and Discovery Mess around and find out Search API Sub Modules When you need more .info.yml files to keep life organized labels Apr 22, 2024
@DiegoPino DiegoPino added this to the 1.4.0 milestone Apr 22, 2024
@DiegoPino
Copy link
Member Author

@alliomeria this what is needed for the Open Ticket you managed today from our spanish/English collections.

@DiegoPino
Copy link
Member Author

Closing in favor of #469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Search and Discovery Mess around and find out Search API Sub Modules When you need more .info.yml files to keep life organized
Projects
None yet
Development

No branches or pull requests

1 participant