Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IIIF settings form needs to have conditional "required" fields. Only if IIIF Search API is enabled #455

Open
DiegoPino opened this issue Jul 11, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@DiegoPino
Copy link
Member

What?

I am old. I make mistakes

The IIIF Settings (which includes now IIIF Content Search API settings) can not have required fields IF the IIIF Content Search API toggle is disabled. Does not allow saving if e.g a humble / NO OCR/ NO strawberry runners server uses recent code

@alliomeria 🫤

@DiegoPino DiegoPino added the bug Something isn't working label Jul 11, 2024
@DiegoPino DiegoPino added this to the 1.4.0 milestone Jul 11, 2024
@DiegoPino DiegoPino self-assigned this Jul 11, 2024
@alliomeria
Copy link
Contributor

No worries @DiegoPino, not the most common use case to arise. Thank you for your great work on the IIIF configurations and for fixing this minor blip in the form.

@DiegoPino
Copy link
Member Author

Pending. Will have to wait until 1.5.0. Sorry folks

@DiegoPino DiegoPino modified the milestones: 1.4.0, 1.5.0 Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants