Skip to content

rmt-legacy module doesn't compile #558

@z-jxy

Description

@z-jxy

Bug description

Compilation for the rmt-legacy module is broken as there's a missing comma in the cfg_attr attribute

esp-idf-hal/src/lib.rs

Lines 101 to 103 in 15e197e

#[cfg_attr(
feature = "rmt-legacy"
deprecated(

expected `,`, found `deprecated`
the valid syntax is `#[cfg_attr(condition, attribute, other_attribute, ...)]`
for more information, visit <https://doc.rust-lang.org/reference/conditional-compilation.html#the-cfg_attr-attribute>
  • Would you like to work on a fix? Y

To Reproduce

Enable the rmt-legacy feature

I'm using commit 34d947d, but it's still an issue on the latest commit to main (15e197e)

esp-idf-hal = { git = "https://github.com/esp-rs/esp-idf-hal" }

Expected behavior

Code should compile

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions