Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new chip detect magic value, ability to read chip revision for ESP32-P4 #686

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Add new chip detect magic value, ability to read chip revision for ESP32-P4 #686

merged 2 commits into from
Oct 7, 2024

Conversation

jessebraham
Copy link
Member

Minor updates, nothing exciting.

Output:

jesse@mbp ~/W/espflash git:feature/esp32p4 [ ✎ ⚑ ]
🦀 [email protected] λ espflash board-info
[2024-10-07T10:36:33Z INFO ] Detected 2 serial ports
[2024-10-07T10:36:33Z INFO ] Ports which match a known common dev board are highlighted
[2024-10-07T10:36:33Z INFO ] Please select a port
[2024-10-07T10:36:34Z INFO ] Serial port: '/dev/cu.usbmodem14201'
[2024-10-07T10:36:34Z INFO ] Connecting...
[2024-10-07T10:36:34Z INFO ] Using flash stub
Chip type:         esp32p4 (revision v0.1)
Crystal frequency: 40 MHz
Flash size:        16MB
Features:          High-Performance MCU
MAC address:       60:55:f9:f9:04:5e

And when using esptool.py get_security_info (output has been truncated):

jesse@mbp ~/W/espflash git:feature/esp32p4 [ ✎ ⚑ ]
🦀 [email protected] λ esptool.py get_security_info
esptool.py v4.8.1
Found 2 serial ports
Serial port /dev/cu.usbmodem14201
Connecting...
Detecting chip type... ESP32-P4
Chip is unknown ESP32-P4 (revision v0.1)
Features: High-Performance MCU
Crystal is 40MHz
MAC: 60:55:f9:f9:04:5e

[...]

jessebraham
jessebraham commented Oct 7, 2024
View reviewed changes
espflash/src/targets/esp32p4.rs
@@ -20,7 +20,7 @@ const FLASH_RANGES: &[Range<u32>] = &[
const PARAMS: Esp32Params = Esp32Params::new(
0x2000,
0x1_0000,
0x3f_0000, // TODO: Update
0x3f_0000,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why I had added this originally, seems to work fine for now so just removed the comment.

@jessebraham jessebraham mentioned this pull request Oct 7, 2024
Open
5 tasks
@SergioGasquez SergioGasquez linked an issue Oct 7, 2024 that may be closed by this pull request
chip_detect_error on ESP32-P4 #679
Open
SergioGasquez
SergioGasquez approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@SergioGasquez SergioGasquez added this pull request to the merge queue Oct 7, 2024
Merged via the queue into esp-rs:main with commit c119e61 Oct 7, 2024
28 checks passed
@jessebraham jessebraham deleted the feature/esp32p4 branch October 7, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chip_detect_error on ESP32-P4
2 participants
@jessebraham @SergioGasquez