Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

espup installs potential riscv targets that are never used #388

Open
Vollbrecht opened this issue Nov 6, 2023 · 2 comments
Open

espup installs potential riscv targets that are never used #388

Vollbrecht opened this issue Nov 6, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Vollbrecht
Copy link
Contributor

Bug description

If i understand it correctly espup just reuse the build-artifacts from crosstool. Currently it installs gcc libs for the following 4 targets in the case of the riscv eco-system.

  • rv32i_zicsr_zifencei
  • rv32imac_zicsr_zifencei
  • v32imafc_zicsr_zifencei
  • rv32imc_zicsr_zifencei
    This libs are relative huge, and if never used should not be installed.

To Reproduce

Steps to reproduce the behavior:

install esp toolchain with espup

Expected behavior

Only install tools that eventually will be used

Screenshots

Bildschirmfoto vom 2023-11-05 10-54-26

Proposal

If its true that we only use the imc and imac targets i would want that the installer directly delete the other for me ( simple option) or that croostool only produces that one that espressif uses.

@Vollbrecht Vollbrecht added the bug Something isn't working label Nov 6, 2023
@github-project-automation github-project-automation bot moved this to Todo in esp-rs Nov 6, 2023
@SergioGasquez SergioGasquez added enhancement New feature or request and removed bug Something isn't working labels Nov 6, 2023
@SergioGasquez
Copy link
Member

This would slim-down what espup install, but it might not be worth to invest time into something that should be temporary, as soon as we can use LLD as linker for no_std, espup won't install GCC at all.

We can leave the issue open for the moment, in case LLD supports takes too long to land, but hopefully it won't take too much!

@Vollbrecht
Copy link
Contributor Author

also now less relevant duo to: #391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants