Skip to content

Inconsistency: "blinky" instructions refer to different API than example #66

@DavidAntliff

Description

@DavidAntliff

This sentence does not match the example "solution" and the HAL API in use:

✅ Initiate the Io peripheral, and create a `led` variable from GPIO connected to the LED, using the
[`into_push_pull_output` function][into-push-pull-output].

https://github.com/esp-rs/no_std-training/blob/main/book/src/03_2_blinky.md?plain=1#L30C1-L32C1

The esp-hal API requires that the led variable be created as an Output using the Output::new() function:

https://docs.rs/esp-hal/0.23.1/esp_hal/gpio/index.html

The similarly named esp32-hal crate has a function called into_push_pull_output() which might be where this inconsistency arose.

I think I've got this the right way around. Regardless of which API is meant to be used, the example solution and the docs don't match.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions