Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'always' as a valid time refresh value #4392

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

mbo18
Copy link
Contributor

@mbo18 mbo18 commented Oct 25, 2024

Description:

Add 'always' as a valid time value. It is more explicit to user than 0s ou 0ms and already supported is the core code, see:
https://github.com/esphome/esphome/blob/21cb941bbe7afb7096ee342fae2c88bdaa27d28b/esphome/config_validation.py#L1981C26-L1981C32

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable): esphome/esphome#

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 488c8de
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/671b8cbd4b8ac10009a5c44c
😎 Deploy Preview https://deploy-preview-4392--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Oct 25, 2024

Walkthrough

The documentation for ESPHome's configuration types has been updated to include a new option for the update_interval configuration variable. The new option, update_interval: always, is now documented as a valid configuration that functions identically to update_interval: 0ms, indicating updates should occur in every loop iteration. This change clarifies the available configuration options for users regarding update frequency.

Changes

File Change Summary
guides/configuration-types.rst Added documentation for update_interval: always configuration option.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Documentation
    participant ESPHome

    User->>Documentation: View configuration types
    Documentation->>User: Display options
    User->>Documentation: Learn about update_interval
    Documentation->>User: Show update_interval: always
    User->>ESPHome: Configure update_interval: always
    ESPHome->>User: Process updates in every loop iteration
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
guides/configuration-types.rst (1)

163-165: Consider restructuring special update_interval values for better clarity.

The special values (never, 0ms, always) could be more clearly organized. Consider using a bullet list or table format:

-      update_interval: never  # never update
-      update_interval: 0ms  # update in every loop() iteration
-      update_interval: always # same as 0ms
+      # Special update_interval values:
+      #  - never: never update
+      #  - 0ms or always: update in every loop() iteration
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between bac5e2a and 488c8de.

📒 Files selected for processing (1)
  • guides/configuration-types.rst (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
guides/configuration-types.rst (1)

Pattern **: - Do not generate or add any sequence diagrams

🔇 Additional comments (1)
guides/configuration-types.rst (1)

165-165: LGTM! The addition is clear and well-placed.

The new 'always' option is documented correctly and its equivalence to '0ms' is clearly stated.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mbo18 👍

../Frenck

@frenck frenck merged commit 5b073d0 into esphome:current Nov 15, 2024
4 checks passed
@mbo18 mbo18 deleted the patch-1 branch November 15, 2024 16:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants