-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update i2c.rst #4580
Update i2c.rst #4580
Conversation
esphome/esphome#6145 Allows esp8266 to handle multiple i2c busses, tested and working.
WalkthroughThe pull request involves a minor grammatical modification in the documentation for the I²C bus component. A comma was removed from a note section in the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/i2c.rst (1)
47-47
: Consider adding ESP8266 support information.Based on the PR objectives, this update enables ESP8266 to manage multiple I²C buses. Consider explicitly mentioning ESP8266 support in the note section to make it clearer for users.
- If the device can support multiple I²C buses these buses need to be defined as below and sensors need to be setup specifying the correct bus: + If the device can support multiple I²C buses (supported on both ESP32 and ESP8266) these buses need to be defined as below and sensors need to be setup specifying the correct bus:
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/i2c.rst
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
components/i2c.rst (1)
Pattern **
: - Do not generate or add any sequence diagrams
🔇 Additional comments (1)
components/i2c.rst (1)
47-47
: LGTM! The comma removal improves readability.The sentence flows better without the comma after "buses".
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
esphome/esphome#6145
Allows esp8266 to handle multiple i2c busses, tested and working.
Description:
Related issue (if applicable): fixes
Pull request in esphome with YAML changes (if applicable): esphome/esphome#
Checklist:
I am merging into
next
because this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
current
because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/index.rst
when creating new documents for new components or cookbook.