Skip to content

add examples for Waveshare ESP32-S3-ETH PoE board #4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2025

Conversation

btittelbach
Copy link
Contributor

Description:

Finding the pins and documentation for this board is a bit like a scavenger hunt.
Adding the information to the documentation examples should make this easier for a lot of people.

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /components/index.rst when creating new documents for new components or cookbook.

add configuration for Waveshare ESP32-S3-ETH PoE OV2640 CAM, especially the power_down_pin which is needed to make it work.
added Ethernet configuration for WaveShare ESP32-S3-ETH with optional PoE-Module
Copy link
Contributor

coderabbitai bot commented Jun 13, 2025

Walkthrough

New configuration examples for the Waveshare ESP32-S3 ETH + OV2640 camera and the Waveshare ESP32-S3-ETH PoE Ethernet board have been added to the documentation. These examples provide explicit pin assignments and settings for each hardware component. No changes to code logic or public interfaces were made.

Changes

File(s) Change Summary
components/esp32_camera.rst Added a configuration example for the Waveshare ESP32-S3 ETH + OV2640 camera, detailing pin mappings.
components/ethernet.rst Added a configuration example for the Waveshare ESP32-S3-ETH PoE board using the W5500 SPI chipset.

Suggested reviewers

  • jesserockz

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a103f13 and 2683552.

📒 Files selected for processing (2)
  • components/esp32_camera.rst (1 hunks)
  • components/ethernet.rst (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**`: - Do not generate or add any sequence diagrams

**: - Do not generate or add any sequence diagrams

  • components/ethernet.rst
  • components/esp32_camera.rst
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build
🔇 Additional comments (2)
components/ethernet.rst (1)

318-329: Formatting looks consistent and complete for the new Ethernet example.
The Waveshare ESP32-S3-ETH PoE configuration follows the existing pattern, clearly specifies all W5500 SPI pins, and matches other entries in this section.

components/esp32_camera.rst (1)

505-525: Verify camera example pin assignments.
Please confirm that the OV2640 camera on the Waveshare ESP32-S3 is wired to these GPIOs and whether a reset_pin should also be included in the example.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jun 13, 2025

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 9503461
🔍 Latest deploy log https://app.netlify.com/projects/esphome/deploys/685c85ce85dd5c00089b858b
😎 Deploy Preview https://deploy-preview-4994--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jesserockz jesserockz merged commit 3e5beec into esphome:current Jun 25, 2025
2 of 3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants