-
Notifications
You must be signed in to change notification settings - Fork 1.4k
publish wheels (ESPTOOL-1027) #1073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello dimbleby, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. Click to see more instructions ...
Review and merge process you can expect ...
|
oh I see, there is quite the tangle here because script installation is oddly different on windows and linux, and doing the conventional thing seems difficult because you have your commands ending I will push a second commit on this branch that simplifies everything to look more normal, but it is a breaking change in the sense that eg the command Mostly that is what people want! But maybe not, I dunno. |
Hello @dimbleby, Thank you for the contribution! This has been considered for a long time. Currently, we are keeping the As we are currently working on a new v5 major release on master, this breaking change is being considered again. At this moment, we cannot merge this in this state - ideally, we want to keep a way to run both aliases If you feel like it, you can help to discover this possibility. Aynway, I will keep this open until we find an acceptable solution! Thanks again. |
Also, making this switch will require more work - e.g. extensive changes in the documentation and the test suite (see the failing CI jobs above). |
My interest is more generally in encouraging projects to publish wheels, and not specifically in this project. If, before I started, I had understood the hole that you have dug for yourselves here then I would likely have left this one alone! If you have a major release coming up then I do encourage you to take the opportunity to disentangle this, likely by continuing in the direction that this pull request points. But I do not expect to contribute any further work to that effort. |
In that case, I am closing this PR. We will deal with the "hole" ourselves, thank you. |
build and publish wheels