feat(spi_nand_flash): implement CTRL_TRIM in fatfs diskio layer #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrr
reviewed
Nov 5, 2024
igrr
reviewed
Nov 5, 2024
|
LGTM, only two minor comments. |
RathiSonika
force-pushed
the
feat/nand_flash_impl_CTRL_TRIM
branch
from
9019655
to
41e83e1
Compare
igrr
approved these changes
Nov 5, 2024
|
@RathiSonika Are you planning any other spi_nand_flash tasks in the next few days? If not them maybe we can bump the component version to release this and #437 features. |
|
Thank you for the reminder—I forgot to update it. I'll make the change in this PR |
RathiSonika
force-pushed
the
feat/nand_flash_impl_CTRL_TRIM
branch
from
41e83e1
to
e7fa7e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Added API spi_nand_flash_trim() to nand.c for trimming sectors from NAND Flash.
Also added CTRL_TRIM to diskio layer to propagate dhara_map_trim() using spi_nand_flash_trim()