assemble: Switch journal_selector over to using name:prefix instead of estuary.dev/collection
#2108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshearer
force-pushed
the
assemble/name_prefix
branch
3 times, most recently
from
551d853 to
ff5d3b4
Compare
Member
|
what's up with catalog tests here? |
Member
jshearer
force-pushed
the
assemble/name_prefix
branch
from
ff5d3b4 to
f428b52
Compare
…ad of `estuary.dev/collection`
jshearer
force-pushed
the
assemble/name_prefix
branch
from
f428b52 to
58e60a5
Compare
| config_json: b"{\"image\":\"someMaterializationImage\",\"config\":{\"any\":\"thing\"}}", | ||
| bindings: [], | ||
| config_json: "{\"image\":\"someMaterializationImage\",\"config\":{\"any\":\"thing\"}}", | ||
| bindings: [ |
Member
There was a problem hiding this comment.
Whoa what's happening here? this snapshot change is not expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This came out of a convo I had with @jgraettinger. We should now be in a state where this change can be deployed, and it should result in some amount of performance improvement for some Gazette RPCs, so let's get it out.
Edit: Need to update more snapshots here
This change is