Update netsuite-suiteanalytics.md #2512
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jwhartley
requested changes
Nov 19, 2025
Contributor
jwhartley
left a comment
jwhartley
left a comment
There was a problem hiding this comment.
- Hah, you've left the LLM writing at the top of the change - please remove that
- Actual docs change looks good
- There's a dash added at the bottom of the file, do you know what that's for?
- The name of the doc in the preview is showing as 'netsuite-suiteanalytics' in the sidebar, I assume this is because of the LLM writing at the top taking away the title inference, but please double-check when updated
Changed a few key details per James' recommendations and notes.
aeluce
requested changes
Nov 25, 2025
Collaborator
aeluce
left a comment
aeluce
left a comment
There was a problem hiding this comment.
This PR will need some changes before merging: it causes some breakages, introduced in the latest update (note that the PR preview deployment is now failing its check). For any changes you're unsure of, you can also run the docs site locally to test things out.
| @@ -1,5 +1,3 @@ | |||
| import ReactPlayer from "react-player"; | |||
Collaborator
There was a problem hiding this comment.
This line should not be removed: we need to import ReactPlayer since we embed a video on this page.
| log_cursor: lastmodifieddate | ||
| target: ${PREFIX}/${CAPTURE_NAME}/transaction | ||
| {...} | ||
| ``` |
Collaborator
There was a problem hiding this comment.
This line of triple backticks is needed to close off the code block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
(Describe the high level scope of new or changed features)
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)