Merge pull request #19432 from 1911860538/feat/server-lease

serathius · web-flow · commit 1e3710a90f93 · 2025-02-18T09:14:20.000+01:00
perf: use RLock in Demoted method for read-only access to expiry
diff --git a/server/lease/lease.go b/server/lease/lease.go
@@ -97,8 +97,8 @@ func (l *Lease) forever() {
 
 // Demoted returns true if the lease's expiry has been reset to forever.
 func (l *Lease) Demoted() bool {
-	l.expiryMu.Lock()
-	defer l.expiryMu.Unlock()
+	l.expiryMu.RLock()
+	defer l.expiryMu.RUnlock()
 	return l.expiry == forever
 }
 

Original file line number	Diff line number	Diff line change
`@@ -97,8 +97,8 @@ func (l *Lease) forever() {`
`97`	`97`
`98`	`98`	`// Demoted returns true if the lease's expiry has been reset to forever.`
`99`	`99`	`func (l *Lease) Demoted() bool {`
`100`		`- l.expiryMu.Lock()`
`101`		`- defer l.expiryMu.Unlock()`
	`100`	`+ l.expiryMu.RLock()`
	`101`	`+ defer l.expiryMu.RUnlock()`
`102`	`102`	`return l.expiry == forever`
`103`	`103`	`}`
`104`	`104`