Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate distributed tracing flags off experimental prefix #19096

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

migrate distributed tracing flags off experimental prefix #19096

wants to merge 1 commit into from
+179 −99

Conversation

omerap12
Copy link

@omerap12 omerap12 commented Dec 22, 2024 •
edited
Loading

Fixes: #19050
Move distributed tracing related flags:

  • experimental-enable-distributed-tracing
  • experimental-distributed-tracing-address
  • experimental-distributed-tracing-service-name
  • experimental-distributed-tracing-instance-id
  • experimental-distributed-tracing-sampling-rate

The experimental flags are marked as deprecated and will be decommissioned in v3.7.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @omerap12. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@serathius
Copy link
Member

/ok-to-test

@codecov Codecov
Copy link

codecov bot commented Dec 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.59091% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.79%. Comparing base (8731c31) to head (60ff730).

Files with missing lines Patch % Lines
server/embed/config.go 83.33% 1 Missing and 1 partial ⚠️
server/embed/config_tracing.go 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/config/config.go 80.23% <ø> (ø)
server/embed/etcd.go 76.45% <100.00%> (-0.05%) ⬇️
server/etcdmain/config.go 73.80% <100.00%> (+0.97%) ⬆️
server/etcdserver/api/v3rpc/grpc.go 100.00% <100.00%> (ø)
server/embed/config_tracing.go 82.60% <87.50%> (ø)
server/embed/config.go 79.50% <83.33%> (-0.09%) ⬇️

... and 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19096      +/-   ##
==========================================
- Coverage   68.85%   68.79%   -0.07%     
==========================================
  Files         420      420              
  Lines       35680    35692      +12     
==========================================
- Hits        24569    24554      -15     
- Misses       9689     9708      +19     
- Partials     1422     1430       +8

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8731c31...60ff730. Read the comment docs.

@omerap12 omerap12 force-pushed the migrate-experiminal-enable-distributed-tracing branch from 36d8406 to a5e8b66 Compare December 31, 2024 12:51
@omerap12
Copy link
Author

omerap12 commented Dec 31, 2024 •
edited
Loading

Hey @serathius, I’m running into some issues with gofumpt 😄

siyuanfoundation
siyuanfoundation reviewed Jan 7, 2025
View reviewed changes
server/etcdmain/config_test.go Outdated
}
defer os.Remove(tmpfile.Name())

err = os.WriteFile(tmpfile.Name(), []byte(tc.yamlConfig), 0600)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use mustCreateCfgFile

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 9448afd

@serathius
Copy link
Member

Hey @serathius, I’m running into some issues with gofumpt 😄

Can you run make fix-lint?

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omerap12
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@omerap12
Copy link
Author

omerap12 commented Jan 8, 2025

Hey @serathius, I’m running into some issues with gofumpt 😄

Can you run make fix-lint?

Fixed, thanks!

@siyuanfoundation
Copy link
Contributor

can you also update references to ExperimentalEnableDistributedTracing in other places like server/embed/etcd.go and server/etcdserver/api/v3rpc/grpc.go?
And the parameters like ExperimentalEnableDistributedTracing in server/config/config.go needs to be updated.

@omerap12
Copy link
Author

/retest

@omerap12
Copy link
Author

PTAL @siyuanfoundation

@ahrtr
Copy link
Member

ahrtr commented Jan 23, 2025

This PR needs rebase and squash.

@omerap12 omerap12 mentioned this pull request Jan 23, 2025
Open
@omerap12
Copy link
Author

PTAL @ahrtr , if looks good Ill squash

@ahrtr
Copy link
Member

ahrtr commented Jan 23, 2025

@siyuanfoundation PTAL

@omerap12
Copy link
Author

/retest

@ahrtr
Copy link
Member

ahrtr commented Jan 24, 2025

You need to rebase this PR (of course, also squash the commits).

Please ensure you understand the concept of rebase and how to do rebase, references for you,

@omerap12 omerap12 force-pushed the migrate-experiminal-enable-distributed-tracing branch from fecd920 to 1963aa4 Compare January 25, 2025 11:47
@omerap12 omerap12 force-pushed the migrate-experiminal-enable-distributed-tracing branch from 1963aa4 to 60ff730 Compare January 25, 2025 11:48
@k8s-ci-robot
Copy link

@omerap12: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-e2e-amd64 60ff730 link true /test pull-etcd-e2e-amd64
pull-etcd-e2e-386 60ff730 link true /test pull-etcd-e2e-386
pull-etcd-e2e-arm64 60ff730 link true /test pull-etcd-e2e-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siyuanfoundation siyuanfoundation siyuanfoundation left review comments

Assignees
No one assigned
Labels
area/testing ok-to-test size/L
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate --experimental-enable-distributed-tracing flag to feature gate
5 participants
@omerap12 @k8s-ci-robot @serathius @siyuanfoundation @ahrtr