-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate flag experimental-corrupt-check-time to use corrupt-check-time #19156
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Gang Li <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gangli113 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @gangli113. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 21 files with indirect coverage changes @@ Coverage Diff @@
## main #19156 +/- ##
==========================================
+ Coverage 68.73% 68.77% +0.03%
==========================================
Files 420 420
Lines 35640 35652 +12
==========================================
+ Hits 24498 24520 +22
+ Misses 9717 9704 -13
- Partials 1425 1428 +3 Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Gang Li <[email protected]>
Signed-off-by: Gang Li <[email protected]>
Signed-off-by: Gang Li <[email protected]>
Signed-off-by: Gang Li <[email protected]>
Signed-off-by: Gang Li <[email protected]>
Signed-off-by: Gang Li <[email protected]>
Signed-off-by: Gang Li <[email protected]>
@gangli113: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes: #19141
Move flag experimental-corrupt-check-time
The experimental flags are marked as deprecated and will be decommissioned in v3.7.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.