Skip to content

Commit

Permalink
textLinesMutator: Fix insertions with newlines at the end of a line
Browse files Browse the repository at this point in the history
In such cases the remaining part of the old line is directly pushed to
the splice and we need to ensure it is not an empty string.
  • Loading branch information
webzwo0i authored and rhansen committed Nov 23, 2021
1 parent 34bcc7e commit 148d0a2
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/static/js/Changeset.js
Original file line number Diff line number Diff line change
Expand Up @@ -973,8 +973,9 @@ class TextLinesMutator {
this._curLine += newLines.length;
// insert the remaining chars from the "old" line (e.g. the line we were in
// when we started to insert new lines)
this._curSplice.push(theLine.substring(lineCol));
this._curCol = 0; // TODO(doc) why is this not set to the length of last line?
const remaining = theLine.substring(lineCol);
if (remaining !== '') this._curSplice.push(remaining);
this._curCol = 0;
} else {
this._curSplice.push(...newLines);
this._curLine += newLines.length;
Expand Down

0 comments on commit 148d0a2

Please sign in to comment.