FMA: SuperchainERC20

[tynes]

This ticket will be complete when the SuperchainERC20 FMA is finalized. https://github.com/ethereum-optimism/design-docs/blob/f3aa2db64b1676b5e58ae602acf2ebdba34b617c/security/fma-superchainerc20.md

[tynes]

The status of this FMA is implementing actions.

• add tests for the SuperchainTokenBridge
• monitoring plan

We need to decide if we want specific monitoring or can leverage a single monitoring solution that is able to check that all executing messages do indeed have initiating messages.

[agusduha]

Review:

• Adding missing tests links fix: superchain erc20 FMA #245
• FM1 monitoring does not seem necessary for now, the solution implies tracking for multiple ERC20

[agusduha]

Finalizing PR: #245

[tynes]

Review:

• Adding missing tests links fix: superchain erc20 FMA #245
• FM1 monitoring does not seem necessary for now, the solution implies tracking for multiple ERC20

We agree that monitoring for this is not required, especially since it is possible to create a malicious token that triggers the monitor. We can monitor at a lower layer of the protocol and get all of the benefits without needing to worry about app layer bugs

[mds1]

Reopening just because I left one comment here: #245 (comment)

[agusduha]

Last action item PR: #265
@mds1

[mds1]

Merged and marking this as completed, thank you!