-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Process same-slot slashings before builder payments in Gloas #4726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0xc0de42
wants to merge
2
commits into
ethereum:master
Choose a base branch
from
0xc0de42:fix_same_slot_slashing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,8 @@ | ||
| import random | ||
| from eth2spec.test.helpers.state import next_epoch | ||
|
|
||
| from eth2spec.test.helpers.attestations import get_valid_attestation | ||
|
|
||
| from eth2spec.test.context import ( | ||
| always_bls, | ||
| spec_state_test, | ||
|
|
@@ -9,6 +14,7 @@ | |
| set_builder_withdrawal_credential, | ||
| set_builder_withdrawal_credential_with_balance, | ||
| ) | ||
| from eth2spec.test.helpers.execution_payload import build_empty_execution_payload | ||
|
|
||
|
|
||
| def run_execution_payload_bid_processing(spec, state, block, valid=True): | ||
|
|
@@ -348,6 +354,48 @@ def test_process_execution_payload_bid_slashed_builder(spec, state): | |
|
|
||
| yield from run_execution_payload_bid_processing(spec, state, block, valid=False) | ||
|
|
||
| @with_gloas_and_later | ||
| @spec_state_test | ||
| def test_process_block_then_slash_non_timely_builder(spec, state): | ||
| """ | ||
| Empty-case payment path: | ||
| - A builder posts a successful bid in a block, but the payload is not revealed in time. | ||
| - Builder is slashed | ||
| - Proposer unconditional payment is enforced by moving the bid amount into | ||
| """ | ||
|
|
||
| # Get past genesis | ||
| next_epoch(spec, state) | ||
| next_epoch(spec, state) | ||
|
|
||
| block, builder_index = prepare_block_with_non_proposer_builder(spec, state) | ||
|
|
||
| value = spec.Gwei(1_000_000) | ||
| state.balances[builder_index] = value + spec.MIN_ACTIVATION_BALANCE | ||
|
|
||
| # Create a bid with value amount | ||
| signed_bid = prepare_signed_execution_payload_bid( | ||
| spec, | ||
| state, | ||
| builder_index=builder_index, | ||
| value=value, | ||
| slot=block.slot, | ||
| parent_block_root=block.parent_root, | ||
| ) | ||
|
|
||
| block.body.signed_execution_payload_bid = signed_bid | ||
| yield "pre", state | ||
| yield "block", block | ||
| spec.process_block(state, block) | ||
| # Slash validator | ||
| spec.slash_validator(state, builder_index) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This state change would have to be after the post, but I think it is better to use another format that sorrounds the slashing |
||
| yield "post", state | ||
|
|
||
| payment_slot = spec.SLOTS_PER_EPOCH + (block.slot % spec.SLOTS_PER_EPOCH) | ||
| payment = state.builder_pending_payments[payment_slot] | ||
| assert payment.withdrawal.amount == value | ||
| assert payment.withdrawal.builder_index == builder_index | ||
|
|
||
|
|
||
| @with_gloas_and_later | ||
| @spec_state_test | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good if you
yieldso it would create a test vectorThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perphas one of the operations formats here: tests/formats/operations/README.md