Skip to content

Suggest to queue DataColumnSidecars if they race the block #4736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

Suggest to queue DataColumnSidecars if they race the block #4736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion specs/gloas/p2p-interface.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,8 @@ The following validations MUST pass before forwarding the
**Added in Gloas:**

- _[IGNORE]_ The sidecar's `beacon_block_root` has been seen via a valid signed
execution payload header (builder's bid).
execution payload header (builder's bid). A client MAY queue the sidecar for
Copy link
Contributor

@ensi321 ensi321 Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason to use the word "queue" then just cache?

Copy link
Member Author

@dapplion dapplion Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same language as in previous forks

Copy link
Member

@jtraglia jtraglia Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. https://github.com/search?q=repo%3Aethereum%2Fconsensus-specs%20%22MAY%20queue%22&type=code

processing once the block is retrieved.
- _[REJECT]_ The sidecars's `slot` matches the slot of the block with root
`beacon_block_root`.
- _[REJECT]_ The hash of the sidecar's `kzg_commitments` matches the
Expand Down