Skip to content

fix(electra): pass aggregate.committee_bits to get_committee_indices #4742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(electra): pass aggregate.committee_bits to get_committee_indices #4742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specs/electra/p2p-interface.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ The following convenience variables are re-defined
The following validations are added:

- [REJECT] `len(committee_indices) == 1`, where
`committee_indices = get_committee_indices(aggregate)`.
`committee_indices = get_committee_indices(aggregate.committee_bits)`.
- [REJECT] `aggregate.data.index == 0`
Copy link
Member

@jtraglia jtraglia Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I find this section to be a little confusing. It's missing the aggregate = signed_aggregrate_and_proof.message.aggregate alias. In this PR, could you also add a paragraph near the beginning similar to the following:

consensus-specs/specs/gloas/p2p-interface.md

Lines 250 to 252 in 11e1509

The following validations MUST pass before forwarding the
`payload_attestation_message` on the network, assuming the alias
`data = payload_attestation_message.data`:


###### `blob_sidecar_{subnet_id}`
Expand Down