Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest adding Coin98 Super Wallet #13945

Open
1 of 2 tasks
Kieran2501 opened this issue Sep 24, 2024 · 7 comments
Open
1 of 2 tasks

Suggest adding Coin98 Super Wallet #13945

Kieran2501 opened this issue Sep 24, 2024 · 7 comments
Labels
needs triage 📥 This issue needs triaged before being worked on product 🧰 This involves a product listing revisit Good idea, wont work on at the moment, but would be good to revisit in the future wallet 👛 This issue relates to adding or changing a wallet

Comments

@Kieran2501
Copy link

Wallet name

Coin98 Super Wallet

What type of wallet?

EOA

Wallet description

Coin98 Super Wallet is the leading multi-chain crypto & AI wallet, designed to seamlessly connect users to the crypto world safely and securely.

We now support 120+ networks, including EVMs and non-EVM chains. With 10M+ users in over 170 countries, Coin98 Super Wallet is fulfilling untapped demand and enhancing in-demand utilities in the DeFi space, helping people to access DeFi services effortlessly.

Wallet logo

Coin98-NewLogo_Mark2

Background color for brand logo

#f0c43f

URL to the project

https://coin98.com/

When did the wallet go live to users?

January 2020

What are the fees users may be paying for using your wallet product?

1% service fee for swapping

Does the wallet have an active development team?

https://github.com/coin98

Is the wallet globally accessible?

Globally accessible

Is the wallet available in multiple languages?

Vietnamese, English, Chinese, Japanese, Turkish, Thai, Russian, Spanish, Indonesia, Portugal, Frances

What social links are there for the project?

Twitter: https://x.com/coin98_wallet
Telegram: https://t.me/coin98wallet
Discord: https://discord.com/invite/K6N7ry5K8d
Link3: https://link3.to/coin98_wallet

Does the wallet have a mobile app? If yes, which operating systems are supported (iOS, Android)?

Yes, both iOS and Android
iOS: https://ios.coin98.com/
Android: https://android.coin98.com/

Does the wallet have a desktop app? If yes, which operating systems are supported (Windows, Mac, Linux)?

No

Does the wallet have a browser extension? If yes, which browsers are supported (Chromium, Firefox, Safari)?

Yes
Chrome: https://chrome.coin98.com/

Is it a hardware wallet?

No

What is the availability of your source code?

Closed source

What license is the wallet software released under?

MIT license

Who holds the private keys?

Yes, users have access to their public and private keys. We are a non-custodial wallet

Please describe the measures taken to ensure the wallet's security and provide documentation wherever possible

https://coin98.com/audit

Has the wallet's smart contract code or security modules been audited?

https://coin98.com/audit

Does the wallet have an internal security team?

Yes. Our security team ensures all user private information is not leaked or accessible by any unauthorize personel or without user consent. Also the protection methods are applied to protect attacks from outsiders

Any other security testing that should be noted?

Yes. Security team runs diagnosis frequently to remove any vulnerabilities which may affect user data, system availability

Scam protection?

Yes. We have integrated GoPlus as a service to warn user about potential scams

Does the wallet support connecting to Ethereum applications?

Yes WalletConnect, connect wallet to dapp directly, in wallet browser

Does the wallet support connecting to a hardware wallet?

Yes

Does the wallet support importing Ethereum RPC endpoints?

Yes. https://docs.coin98.com/products/coin98-super-wallet/mobile/asset-management/v15-how-to-add-custom-network-on-coin98-super-wallet

Does the wallet support viewing and interacting with NFTs?

Yes

Does the wallet support staking directly?

Yes. https://docs.coin98.com/products/coin98-staking

Does the wallet support swaps directly?

Yes. https://docs.coin98.com/products/coin98-super-wallet/mobile/swap/how-to-trade-natively

Does the wallet support bridging directly?

Yes. https://docs.coin98.com/products/coin98-super-wallet/mobile/spacegate

Does the wallet support multi-chain networks?

Yes. https://docs.coin98.com/products/coin98-super-wallet/mobile/asset-management/how-to-manage-blockchains-on-coin98-super-app-1

Which Ethereum Layer 2 networks does the wallet support?

Arbitrum, Optimism, Base, Polygon zkEVM, zkSync Era, Mantle, Scroll, Ancient8, Linea, Taiko, Manta Pacific, Metis, Mode, Zora, Blast, ZKFair, Mint, XLayer,...

Does the wallet allow the user to customize gas fees?

Yes. https://docs.coin98.com/products/coin98-super-wallet/mobile/asset-management/v15-how-to-send-a-token

Does the wallet support sending transactions to ENS addresses?

Yes

Does the wallet support importing or automatically querying and displaying ERC-20 tokens?

Yes. https://docs.coin98.com/products/coin98-super-wallet/mobile/asset-management/v15-how-to-add-a-custom-token-on-coin98-super-wallet

Does the wallet support EIP-1559 (type 2) transactions?

Yes

Does the wallet have any recovery options?

Yes. https://docs.coin98.com/products/coin98-super-wallet/mobile/wallet-management/v15-how-to-import-multi-chain-wallets-to-coin98-super-wallet

Does the wallet have fiat on-ramps through credit/debit cards, wire transfers, or bank transfers (ACH)?

Yes. https://docs.coin98.com/products/coin98-super-wallet/mobile/getting-started/how-to-buy-cryptocurrency-by-fiat-1

Does the wallet support withdrawals to fiat?

No

Is the wallet a multi-signature wallet?

No

Does the wallet support social recovery?

No

Does the wallet support bundled transactions?

Yes. https://docs.coin98.com/products/coin98-super-wallet/extension/beginners-guide/multi-send

Who can the ethereum.org team can contact regarding the wallet in future?

Telegram: @kieran_coin98

Does the wallet have a dedicated support team?

Yes, we have live support 24/7. https://livechat.coin98.com/

What educational resources/documentation do you provide to users?

User and developer documentations are available in https://docs.coin98.com/

Does the wallet have any integrated tools not mentioned above?

Vault, Exchange, Portfolio, Cloud Backup, Revoke, Faucet, Token Issuer, NFT Issuer, DApp Browser, In-app Marketplace, In-app Chat, and more

Would you like to work on this issue?

  • Yes
  • No
@Kieran2501 Kieran2501 added product 🧰 This involves a product listing wallet 👛 This issue relates to adding or changing a wallet labels Sep 24, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Sep 24, 2024
@konopkja
Copy link
Contributor

konopkja commented Oct 16, 2024

Hello @Kieran2501, we have received this feedback about Coin98 app before from our community, could you please share some response before we move on:

Community member about Coin 98 security:

If the site sends a message with the parameter "isDev:true," the Content Script forwards it directly to the extension's background script using the runtime.sendMessage() function.

This gives the attacker the power to make the victim's wallet sign and submit transactions.

The severity of this issue is exacerbated by the following factors:

  • Victim doesn't need to accept a connection to a malicious dapp.
  • The attack happens silently in the background, without giving any alert or feedback to the user.

The attack works even when the Coin98 wallet is locked, the attacker doesn’t need to know the wallet password.

Its worth noting that this was discovered in early 2023, the wallet team said at the time that its users responsibility not to go to malicious websites.

@konopkja
Copy link
Contributor

Is still unsolved? admittedly its a bit old information, but checking first

@konopkja konopkja added revisit Good idea, wont work on at the moment, but would be good to revisit in the future and removed needs triage 📥 This issue needs triaged before being worked on labels Oct 16, 2024
@konopkja
Copy link
Contributor

closing this until response

@Kieran2501
Copy link
Author

Hi @konopkja,

This security problem has been resolved in the latest version of the extension.
Our team has reviewed and removed all relative code from 9.x version.

Thank you!

@konopkja konopkja reopened this Nov 4, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Nov 4, 2024
@konopkja
Copy link
Contributor

konopkja commented Nov 4, 2024

Hi @konopkja,

This security problem has been resolved in the latest version of the extension. Our team has reviewed and removed all relative code from 9.x version.

Thank you!

perfect, thats good to hear! Do you want to create PR adding the wallet?

@Kieran2501
Copy link
Author

hi @konopkja,

We have submitted it, please help us check here #14319

@Kieran2501
Copy link
Author

hi @konopkja, please let us know if we are missing any additional information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage 📥 This issue needs triaged before being worked on product 🧰 This involves a product listing revisit Good idea, wont work on at the moment, but would be good to revisit in the future wallet 👛 This issue relates to adding or changing a wallet
Projects
None yet
Development

No branches or pull requests

2 participants