Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: fix tests according to spec #410

Open
renaynay opened this issue Nov 30, 2020 · 0 comments
Open

graphql: fix tests according to spec #410

renaynay opened this issue Nov 30, 2020 · 0 comments
Assignees

Comments

@renaynay
Copy link
Contributor

I'm making a reference issue here to follow up on a couple of inconsistencies between the graphql tests and the graphql spec.

I opened an issue on Besu to discuss differences between geth and besu graphql implementations. In some areas, geth is not compliant with the spec (which will be fixed shortly), but Besu also implemented queries on Account which was discussed here, but never formally included in the spec. Also Besu returns numbers for Status whereas the spec asks for Long (geth returns hex strings for Status).

So far, here are the inconsistencies / issues:

  • Status -- spec asks for Long. Geth returns hex string (which is presumably correct) and Besu returns number. Graphql tests currently expect a number which is incorrect.
  • Gas-related queries (estimateGas, cumulativeGas, gasLimit, gasUsed) should return number instead of hex string -- geth is working on fixing this. Besu has it correctly implemented.
  • Block number queries should return number instead of hex string -- geth is working on fixing this. Besu has it correctly implemented.
  • Queries on Account should either be formally included in the spec (in which case, should also be implemented in geth) or removed from the graphql test suite.
@renaynay renaynay self-assigned this Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant