Skip to content
This repository was archived by the owner on Jul 1, 2021. It is now read-only.
This repository was archived by the owner on Jul 1, 2021. It is now read-only.

JsonRpcServerComponent runs background services and never checks on them #1774

@gsalgado

Description

@gsalgado

That component is also affected by the fire-and-forget anti pattern:

async with contextlib.AsyncExitStack() as stack:
managers = tuple([
await stack.enter_async_context(background_asyncio_service(service))
for service in services_to_exit
])
await managers[0].wait_finished()

That component runs until the first started service's wait_finished() returns (which can be due to a service crashing). Instead it should probably exit as soon as any of the started services wait_finished()` returns

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions