LedgerSigner.connect always throws an error

[prestwich]

Describe the bug
calling connect on a LedgerSigner instance throws an error

Likely related to the underlying HID transport holding the device, and the new signer making a second acquisition attempt that fails

Reproduction steps

import { LedgerSigner } from '@ethersproject/hardware-wallets'
import * as ethers from 'ethers'

const provider = ethers.providers.getDefaultProvider()
const signer = new LedgerSigner()

signer.connect(provider)

/// Error: cannot open device with path

Environment
ts-node w/ node@16.6.2 on an M1 macbook

[ricmoo]

The hardware-wallets package is quite out of date right now as a result of Chrome removing u2f support, the new LedgerLive web-socket proxy work-around and some major bumps in dependencies.

I'm working on this as an ancillary package so I can recruit the help of others to keep it maintained, but also trying to get v6 out, so I won't be able to get to this right away. :s

[timrowley-dev]

The hardware-wallets package is quite out of date right now as a result of Chrome removing u2f support, the new LedgerLive web-socket proxy work-around and some major bumps in dependencies.

I'm working on this as an ancillary package so I can recruit the help of others to keep it maintained, but also trying to get v6 out, so I won't be able to get to this right away. :s

So would it be safe to say the Ledger package is broken right now? I can't connect at all, even when trying to change the type to "hid" I get:
-> ledger = new LedgerSigner(provider, "hid");
Uncaught (in promise) Error: unknown or unsupported type (argument="type", value="hid", code=INVALID_ARGUMENT, version=hardware-wallets/5.4.0)

[FrozenKiwi]

Hi @ricmoo - is the ancillary package available? I've run into issued deploying to polygon. I'd be happy to fork hardware-signers and submit a fix; forking the whole ethers package isn't a big deal but it does make it slightly more complicated to refer to my custom package while waiting for the PR to merge.

The package is mostly working, but ledger has an issue with chain Ids > 127: https://github.com/LedgerHQ/ledgerjs-legacy/blob/6d655aa89b748e50ae15c0cfb30c08f2215f6d84/packages/web3-subprovider/src/index.js#L143

[prestwich]

I fixed the issue in Node. This makes ledger Eth objects into singletons, so they are reused by LedgerSigner. This allows instantiation of multiple LedgerSigners, as well as using the Signer.connect() function without error.

I have not yet tested these changes in browser, as that would require updating u2f. Tried to design eth.ts it such that a build system could simply swap out ledger-transport.ts for browser-ledger-transport.ts at build time without issues, and such that we could add more transports easily

Uploading as a zip file, as I can't find contributor documentation on build/formatting/lint systems. This is intended for packages/hardware-wallets/src.ts

src.ts.zip

[mdnorman]

@prestwich thanks! I had issues with the 5.5.0 version as well, and your version seems to work for me. I was thinking of doing something similar after spending a while digging into the @ledgerhq code, so I appreciate it!

Can a contributor get this change added?

[ricmoo]

Can you try out this latest version and see if you still have issues with it? I believe the underlying issue may have been fixed by Ledger, as this package creates a new Eth object for each necessary call, and it has worked for me.