Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pymode_doc_key name changed to pymode_doc_bind in 0.7.8b #33

Closed
alphaCTzo7G opened this issue Nov 15, 2017 · 3 comments
Closed

pymode_doc_key name changed to pymode_doc_bind in 0.7.8b #33

alphaCTzo7G opened this issue Nov 15, 2017 · 3 comments
Assignees
Labels

Comments

@alphaCTzo7G
Copy link

Hi

In this line, it uses pymode_doc_key:

let g:pymode_doc_key='K'

However, python-mode has change the variable name pymode_doc_key to pymode_doc_bind in version 0.7.8b (https://github.com/python-mode/python-mode/blob/b848f6294ca5858fd17eaf14783fa2042e8142b7/Changelog.rst#L81).

Would you it be ok, if I do a PR to update the variable?

@rmk135 rmk135 self-assigned this Nov 16, 2017
@rmk135 rmk135 added the bug label Nov 16, 2017
@rmk135
Copy link
Member

rmk135 commented Nov 16, 2017

Hi there,

Yeah, definitely! Please, go ahead!

... Didn't know about this. I would merge it ASAP.

Thanks a lot,
Roman

@rmk135
Copy link
Member

rmk135 commented Nov 22, 2017

Hi @alphaCTzo7G ,

How are you? Just wanted to ask you if you still plan to propose PR for fixing this problem?

Thanks,
Roman

@rmk135
Copy link
Member

rmk135 commented Jan 15, 2018

Fixed in 1857464.

@rmk135 rmk135 closed this as completed Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants