Error while importing: SyntaxError: Named export 'ContainerTypes' not found. The requested module 'express-joi-validation' is a CommonJS module

[mukhammad-akilov]

I am facing SyntaxErro while trying to import from express-joi-validation:

`
import { ContainerTypes, createValidator, } from 'express-joi-validation';
^^^^^^^^^^^^^^
SyntaxError: Named export 'ContainerTypes' not found. The requested module 'express-joi-validation' is a CommonJS
module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'express-joi-validation';
const { ContainerTypes, createValidator, } = pkg;
`

I have the following tsconfig.json:
{ ..... "target": "ES2020", "lib": [ "ES6", ], "module": "NodeNext", ..... }

Any package.json looks like this:
.... "type": "module" ......

The whole project is located in this repository:
https://github.com/mukhammad-akilov/epam-nodejs-mentoring

Could you please go to hometask-3 branch and run npm run home-task-2

[mukhammad-akilov]

@evanshortiss Need your help :)

[evanshortiss]

Can you create a smaller repo to produce this? This worked fine for me on node 18.9 and tsc 4.9.4:

import express, {NextFunction, Response} from 'express';
import Joi from 'joi'
import {
  // Use this as a replacement for express.Request
  ValidatedRequest,
  ContainerTypes,
  // Extend from this to define a valid schema type/interface
  ValidatedRequestSchema,
  // Creates a validator that generates middlewares
  createValidator
} from 'express-joi-validation';

interface CraeteUserRequestSchema extends ValidatedRequestSchema {
  [ContainerTypes.Fields]: {
    login: string;
    password: string;
    age: number;
  };
}

const app = express()

const validator = createValidator();
app.use(express.json());

export const addSchema = Joi.object({
  login: Joi.string().required(),
  password: Joi.string().alphanum().min(8).max(30).required(),
  age: Joi.number().integer().min(4).max(130).required(),
});


const routeHandler = <T>(fn: (req: T, res: Response) => void) => {
  return (req: T, res: Response, next: NextFunction) => {
    try {
      fn(req, res);
    } catch (error) {
      let message;
      if (error instanceof Error) {
        message = error.message;
      } else {
        message = String(error);
      }
      next(message);
    }
  };
};

app.post(
  '/api/users',
  validator.body(addSchema),
  routeHandler<ValidatedRequest<CraeteUserRequestSchema>>((req, res) => {
    res.status(201).json({});
  }),
);

And:

{
  "compilerOptions": {
    "target": "ES2020",
    "lib": ["ES6"],
    "module": "NodeNext",
    "esModuleInterop": true,
    "forceConsistentCasingInFileNames": true,
    "strict": true,     
    "skipLibCheck": true
  }
}

Edit: and package type "module"

[mukhammad-akilov]

Can you create a smaller repo to produce this? This worked fine for me on node 18.9 and tsc 4.9.4:

import express, {NextFunction, Response} from 'express';
import Joi from 'joi'
import {
  // Use this as a replacement for express.Request
  ValidatedRequest,
  ContainerTypes,
  // Extend from this to define a valid schema type/interface
  ValidatedRequestSchema,
  // Creates a validator that generates middlewares
  createValidator
} from 'express-joi-validation';

interface CraeteUserRequestSchema extends ValidatedRequestSchema {
  [ContainerTypes.Fields]: {
    login: string;
    password: string;
    age: number;
  };
}

const app = express()

const validator = createValidator();
app.use(express.json());

export const addSchema = Joi.object({
  login: Joi.string().required(),
  password: Joi.string().alphanum().min(8).max(30).required(),
  age: Joi.number().integer().min(4).max(130).required(),
});


const routeHandler = <T>(fn: (req: T, res: Response) => void) => {
  return (req: T, res: Response, next: NextFunction) => {
    try {
      fn(req, res);
    } catch (error) {
      let message;
      if (error instanceof Error) {
        message = error.message;
      } else {
        message = String(error);
      }
      next(message);
    }
  };
};

app.post(
  '/api/users',
  validator.body(addSchema),
  routeHandler<ValidatedRequest<CraeteUserRequestSchema>>((req, res) => {
    res.status(201).json({});
  }),
);

And:

{
  "compilerOptions": {
    "target": "ES2020",
    "lib": ["ES6"],
    "module": "NodeNext",
    "esModuleInterop": true,
    "forceConsistentCasingInFileNames": true,
    "strict": true,     
    "skipLibCheck": true
  }
}

Edit: and package type "module"

Thanks for your quick reply.
I created seperate repository for this one:
https://github.com/mukhammad-akilov/node-ts-joi

But there I also face same issue (just run npm run dev command):

My Enviroment:
Node.js version: 18.12.1
TypeScript: 4.9.4

[evanshortiss]

Thanks for that. I see this is a runtime error, and not a compile error as I first assumed.

A quick workaround is to do this:

import { ValidatedRequestSchema, ValidatedRequest, createValidator } from 'express-joi-validation'
import ejv from 'express-joi-validation';
const { ContainerTypes } = ejv;

It seems like the module resolution is trying to import the ContainerTypes enum at runtime, but it's a type that's not used at runtime. I'm guessing it has something to do with the tsconfig module resolution settings but would need more time to look into it.

[mukhammad-akilov]

It fixes ther error but now I am facing another error:

TypeError: Joi.string is not a function

@evanshortiss Please also look at this scenario

[evanshortiss]

@mukhammad-akilov this is a Joi error. Unrelated to this module. My guess is it's related to how Joi is imported.