Give an error on non-existing devices #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everpeace
requested changes
Apr 27, 2023
Owner
everpeace
left a comment
everpeace
left a comment
There was a problem hiding this comment.
Sorry for the late review. Please take a look at comment.
| return nil, err | ||
| } | ||
| if len(matchedHostPath) == 0 { | ||
| return nil, fmt.Errorf("no file matched: %s", d.HostPath) |
Owner
There was a problem hiding this comment.
This is breaking change. Could you introduce feature switch for this??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
This PR will return a fatal error during startup if the configuration doesn't match any devices.
Does this pull request fix one issue?
Fixes #15