Skip to content

Commit dae5a48

Browse files
committed
Fixes from review
1 parent ab2c431 commit dae5a48

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

exasol/nb_connector/slc/script_language_container.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,8 @@ def generate_activation_key(self, add_to_secret_store: bool) -> str:
302302
Can be used in `ALTER SESSION` or `ALTER_SYSTEM` SQL commands to activate
303303
the language of the uploaded script-language-container, for example, if you want to use the SLC in your SQL Editor.
304304
Furthermore, this method can be used as fallback if the deploy-function failed for some reason,
305-
but the script-language-container was uploaded to the BucketFS. Then it will register the Language activation for this SLC in the Secure Configuration Store.
305+
but the script-language-container was uploaded to the BucketFS.
306+
Then it will register the Language activation for this SLC in the Secure Configuration Store.
306307
"""
307308
bfs_params = self._generate_bfs_params_from_secret_store()
308309

test/integration/ordinary/itest_slc.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,9 +187,9 @@ def test_deploy_cert_fails(
187187
def test_deploy(sample_slc: ScriptLanguageContainer, setup_itde_module):
188188
sample_slc.deploy()
189189
assert sample_slc.activation_key == expected_activation_key(sample_slc)
190-
assert sample_slc.generate_activation_key(False) == sample_slc.secrets.get(
191-
sample_slc._alias_key
192-
)
190+
act_key_from_deploy = sample_slc.secrets.get(sample_slc._alias_key)
191+
act_key_from_generate = sample_slc.generate_activation_key(False)
192+
assert act_key_from_deploy == act_key_from_generate
193193

194194

195195
@pytest.mark.dependency(name="append_custom_pip_packages", depends=["deploy_slc"])

0 commit comments

Comments
 (0)