Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing localizable strings #2326

Closed
fadedflower opened this issue Jan 11, 2025 · 2 comments
Closed

Missing localizable strings #2326

fadedflower opened this issue Jan 11, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@fadedflower
Copy link
Contributor

Hi, I noticed there are some localizable strings missing in localizable.strings.

In "Kit/Widgets/Battery.swift"
"XL size" and "Charger state inside the battery"
SCR-20250112-baln

In "Modules/Sensors/settings.swift"
"Sensor to show"
SCR-20250112-bbqh
@exelban exelban added the enhancement New feature or request label Jan 12, 2025
@exelban exelban added this to Stats Jan 12, 2025
@exelban exelban moved this to Todo in Stats Jan 12, 2025
exelban added a commit that referenced this issue Jan 13, 2025
@exelban
lang: added missing translations (#2326)
fcbdb66
@exelban exelban moved this from Todo to Ready to deploy in Stats Jan 13, 2025
@exelban exelban closed this as completed Jan 13, 2025
@github-project-automation github-project-automation bot moved this from Ready to deploy to Done in Stats Jan 13, 2025
@fadedflower
Copy link
Contributor Author

"XL size" is still not added to localizable.strings.

@exelban
Copy link
Owner

exelban commented Jan 13, 2025

yes, cause it must be removed. It was a temporary solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Stats
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@exelban @fadedflower