Skip to content

Sync tests #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 11, 2025
Merged

Sync tests #955

merged 5 commits into from
Jun 11, 2025

Conversation

depial
Copy link
Contributor

@depial depial commented Jun 10, 2025

This updates the tests of anagram and all-your-base as per Issue #948

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@depial
Copy link
Contributor Author

depial commented Jun 10, 2025

We should include [no important files changed] in the commit message.

@depial depial requested a review from colinleach June 10, 2025 19:49
@colinleach
Copy link
Contributor

colinleach commented Jun 10, 2025

I've approved, but recommend not merging yet. There are all sorts of problems with the website today (at the AWS server level). More details on the maintaining channel of Discord. Jeremy is partly aware, but more trouble has surfaced while he's been asleep in Japan.

Bottom line for us: merges on GH don't sync to Exercism. Also, the online editor is misbehaving.

@colinleach
Copy link
Contributor

colinleach commented Jun 11, 2025

I'll try merging this to see what happens.

Update: it worked.

@colinleach colinleach merged commit 686e129 into exercism:main Jun 11, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants