Bowling - inline test helper functions setUp and rollMany

[mk-mxp]

In this forum thread once again a student struggled with DRY'ed tests. We should not hide test details behind helper functions like rollMany() or setUp().

Instead inline all the details into the individual test methods and make students see exactly what is happening, so they can focus on solving the exercises and not be distracted by analysing helper functions or PHP unit test automations.

[mk-mxp]

Also raised in that forum thread was a mismatch between @testdox description and some test names. That also should be corrected.

[keiravillekode]

Another option would be a comment like

$this->rollMany(18, 0); // 9 frames

[mk-mxp]

I'd prefer using the array from problem specs directly and explicitly looping over the function call like this:

    public function testShouldBeAbleToScoreAGameWithAllZeros(): void
    {
        $game = new Game();

        $previousRolls = [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0];

        foreach ($previousRolls as $pins) {
            $game->roll($pins);
        }

        $this->assertEquals(0, $game->score());

This does not at all mention any bowling frames, nor help with identifying them in the rolls sequence. But it shows exactly what is happening using very basic PHP functionality. By using the same loop over and over again, students can once understand the loop, then skip it, and use the array only.

With this solution we can easily use canonical data to re-generate the exercise, too (once we have the generator agreed upon and written).