Skip to content

Commit 98b7f20

Browse files
committed
add missing PoE 2 icons (fixes #167)
1 parent c63b072 commit 98b7f20

File tree

8 files changed

+16
-4
lines changed

8 files changed

+16
-4
lines changed

app/pods/components/page/bookmarks/folder-edition/component.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import {
2525
BookmarksFolderPoE2ItemIcon,
2626
BookmarksFolderStruct,
2727
BookmarksFolderIcon,
28+
BookmarksFolderAscendancyPoE2HuntressIcon,
2829
} from 'better-trading/types/bookmarks';
2930

3031
const POE1_ASCENDANCY_ICONS: Array<Record<string, BookmarksFolderIcon>> = [
@@ -39,11 +40,12 @@ const POE1_ASCENDANCY_ICONS: Array<Record<string, BookmarksFolderIcon>> = [
3940

4041
const POE2_ASCENDANCY_ICONS: Array<Record<string, BookmarksFolderIcon>> = [
4142
BookmarksFolderAscendancyPoE2WarriorIcon,
42-
BookmarksFolderAscendancyPoE2WitchIcon,
43-
BookmarksFolderAscendancyPoE2RangerIcon,
4443
BookmarksFolderAscendancyPoE2SorceressIcon,
45-
BookmarksFolderAscendancyPoE2MercenaryIcon,
44+
BookmarksFolderAscendancyPoE2RangerIcon,
45+
BookmarksFolderAscendancyPoE2HuntressIcon,
4646
BookmarksFolderAscendancyPoE2MonkIcon,
47+
BookmarksFolderAscendancyPoE2MercenaryIcon,
48+
BookmarksFolderAscendancyPoE2WitchIcon,
4749
];
4850

4951
interface Args {

app/types/bookmarks.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,13 @@ export enum BookmarksFolderAscendancyScionIcon {
7676
export enum BookmarksFolderAscendancyPoE2WarriorIcon {
7777
TITAN = 'poe2-titan',
7878
WARBRINGER = 'poe2-warbringer',
79+
SMITH_OF_KITAVA = 'poe2-smith-of-kitava'
7980
}
8081

8182
export enum BookmarksFolderAscendancyPoE2WitchIcon {
8283
INFERNALIST = 'poe2-infernalist',
8384
BLOOD_MAGE = 'poe2-blood-mage',
85+
LICH = 'poe2-lich'
8486
}
8587

8688
export enum BookmarksFolderAscendancyPoE2RangerIcon {
@@ -96,13 +98,19 @@ export enum BookmarksFolderAscendancyPoE2SorceressIcon {
9698
export enum BookmarksFolderAscendancyPoE2MercenaryIcon {
9799
WITCH_HUNTER = 'poe2-witch-hunter',
98100
GEMLING_LEGIONNAIRE = 'poe2-gemling-legionnaire',
101+
TACTICIAN = 'poe2-tactician'
99102
}
100103

101104
export enum BookmarksFolderAscendancyPoE2MonkIcon {
102105
INVOKER = 'poe2-invoker',
103106
ACOLYTE_OF_CHAYULA = 'poe2-acolyte-of-chayula',
104107
}
105108

109+
export enum BookmarksFolderAscendancyPoE2HuntressIcon {
110+
RITUALIST = 'poe2-ritualist',
111+
AMAZON = 'poe2-amazon',
112+
}
113+
106114
export type BookmarksFolderPoE1AscendancyIcon =
107115
| BookmarksFolderAscendancyDuelistIcon
108116
| BookmarksFolderAscendancyShadowIcon
@@ -118,7 +126,8 @@ export type BookmarksFolderPoE2AscendancyIcon =
118126
| BookmarksFolderAscendancyPoE2RangerIcon
119127
| BookmarksFolderAscendancyPoE2SorceressIcon
120128
| BookmarksFolderAscendancyPoE2MercenaryIcon
121-
| BookmarksFolderAscendancyPoE2MonkIcon;
129+
| BookmarksFolderAscendancyPoE2MonkIcon
130+
| BookmarksFolderAscendancyPoE2HuntressIcon;
122131

123132
export enum BookmarksFolderPoE1ItemIcon {
124133
ALCHEMY = 'alchemy',

changelogs/1-9-2-mercenaries-2.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,4 @@
33
## Bug fixes 🐛
44

55
- Fixes bookmark drag-and-drop (thanks @keyos1 for debugging the issue!)
6+
- Adds missing PoE 2 ascendancy icons (Amazon, Lich, Ritualist, Smith of Kitava, Tactician)
15.8 KB
Loading
14.1 KB
Loading
14.4 KB
Loading
13.8 KB
Loading
13.9 KB
Loading

0 commit comments

Comments
 (0)