Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese language support #125

Open
Rigaln opened this issue Dec 11, 2022 · 2 comments
Open

Japanese language support #125

Rigaln opened this issue Dec 11, 2022 · 2 comments
Labels
improvement New feature or request

Comments

@Rigaln
Copy link

Rigaln commented Dec 11, 2022

https://jp.pathofexile.com/trade/search/Sanctum
I would like to request support for the Japanese website.
Also, if possible, I would like to see the extension functionality translated into Japanese.

@dbjorge
Copy link
Contributor

dbjorge commented Dec 11, 2022

Hi, thanks for the feedback!

  • The Japanese website support is a reasonable request, I can look into adding support for that. I'll leave this issue open to track that request.
  • Unfortunately, a Japanese translation for the extension itself isn't something we're likely to support - translations require not just a lot of up front work but also create a permanent ongoing tax on future development, since they have to be updated with every future release, so it's not something I'm comfortable committing to for a language that I don't speak myself.

@dbjorge dbjorge added the improvement New feature or request label Dec 11, 2022
@pboutin
Copy link
Member

pboutin commented Dec 14, 2022

@dbjorge a thing to keep in mind also, there's some enhancers that look for some texts in the DOM (the enhancers).Some versions of the trade site seemed to behave differently iirc. So translating the extension is not only about translating buttons and labels. That's what prevented me from going that way (not being a native english speaker myself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants