Skip to content

Commit e14d854

Browse files
committed
chore: drop deep-equal devDependency
According to deep-equal's own docs: > Node's assert.deepEqual() algorithm as a standalone module, that also works in browser environments. Since the tests are running in Node.js only, we don't need an external dependency.
1 parent 5c8407f commit e14d854

File tree

4 files changed

+17
-21
lines changed

4 files changed

+17
-21
lines changed

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
"xtend": "^4.0.2"
3131
},
3232
"devDependencies": {
33-
"deep-equal": "^2.0.3",
3433
"express": "^4.21.2",
3534
"form-data": "^4.0.2",
3635
"fs-temp": "^1.2.1",

test/disk-storage.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
/* eslint-env mocha */
22

33
var assert = require('assert')
4-
var deepEqual = require('deep-equal')
54

65
var fs = require('fs')
76
var path = require('path')
@@ -71,9 +70,9 @@ describe('Disk Storage', function () {
7170
assert.strictEqual(req.body.version, '')
7271
assert.strictEqual(req.body.year, '')
7372

74-
assert(deepEqual(req.body.checkboxfull, ['cb1', 'cb2']))
75-
assert(deepEqual(req.body.checkboxhalfempty, ['cb1', '']))
76-
assert(deepEqual(req.body.checkboxempty, ['', '']))
73+
assert.deepEqual(req.body.checkboxfull, ['cb1', 'cb2'])
74+
assert.deepEqual(req.body.checkboxhalfempty, ['cb1', ''])
75+
assert.deepEqual(req.body.checkboxempty, ['', ''])
7776

7877
assert.strictEqual(req.file.fieldname, 'empty')
7978
assert.strictEqual(req.file.originalname, 'empty.dat')
@@ -107,7 +106,7 @@ describe('Disk Storage', function () {
107106
util.submitForm(parser, form, function (err, req) {
108107
assert.ifError(err)
109108

110-
assert(deepEqual(req.body, {}))
109+
assert.deepEqual(req.body, {})
111110

112111
assert.strictEqual(req.files.empty[0].fieldname, 'empty')
113112
assert.strictEqual(req.files.empty[0].originalname, 'empty.dat')
@@ -158,10 +157,10 @@ describe('Disk Storage', function () {
158157
util.submitForm(parser, form, function (err, req) {
159158
assert.strictEqual(err.code, 'LIMIT_UNEXPECTED_FILE')
160159
assert.strictEqual(err.field, 'small0')
161-
assert(deepEqual(err.storageErrors, []))
160+
assert.deepEqual(err.storageErrors, [])
162161

163162
var files = fs.readdirSync(uploadDir)
164-
assert(deepEqual(files, []))
163+
assert.deepEqual(files, [])
165164

166165
done()
167166
})

test/fields.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
/* eslint-env mocha */
22

33
var assert = require('assert')
4-
var deepEqual = require('deep-equal')
54
var stream = require('stream')
65

76
var util = require('./_util')
@@ -25,11 +24,11 @@ describe('Fields', function () {
2524

2625
util.submitForm(parser, form, function (err, req) {
2726
assert.ifError(err)
28-
assert(deepEqual(req.body, {
27+
assert.deepEqual(req.body, {
2928
name: 'Multer',
3029
key: 'value',
3130
abc: 'xyz'
32-
}))
31+
})
3332
done()
3433
})
3534
})
@@ -49,14 +48,14 @@ describe('Fields', function () {
4948

5049
util.submitForm(parser, form, function (err, req) {
5150
assert.ifError(err)
52-
assert(deepEqual(req.body, {
51+
assert.deepEqual(req.body, {
5352
name: 'Multer',
5453
key: '',
5554
abc: '',
5655
checkboxfull: ['cb1', 'cb2'],
5756
checkboxhalfempty: ['cb1', ''],
5857
checkboxempty: ['', '']
59-
}))
58+
})
6059
done()
6160
})
6261
})
@@ -107,7 +106,7 @@ describe('Fields', function () {
107106

108107
util.submitForm(parser, form, function (err, req) {
109108
assert.ifError(err)
110-
assert(deepEqual(req.body, test.expected))
109+
assert.deepEqual(req.body, test.expected)
111110
done()
112111
})
113112
})
@@ -122,13 +121,13 @@ describe('Fields', function () {
122121

123122
util.submitForm(parser, form, function (err, req) {
124123
assert.ifError(err)
125-
assert(deepEqual(req.body, {
124+
assert.deepEqual(req.body, {
126125
obj: {
127126
0: 'a',
128127
2: 'c',
129128
x: 'yz'
130129
}
131-
}))
130+
})
132131
done()
133132
})
134133
})

test/memory-storage.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
/* eslint-env mocha */
22

33
var assert = require('assert')
4-
var deepEqual = require('deep-equal')
54

65
var util = require('./_util')
76
var multer = require('../')
@@ -58,9 +57,9 @@ describe('Memory Storage', function () {
5857
assert.strictEqual(req.body.version, '')
5958
assert.strictEqual(req.body.year, '')
6059

61-
assert(deepEqual(req.body.checkboxfull, ['cb1', 'cb2']))
62-
assert(deepEqual(req.body.checkboxhalfempty, ['cb1', '']))
63-
assert(deepEqual(req.body.checkboxempty, ['', '']))
60+
assert.deepEqual(req.body.checkboxfull, ['cb1', 'cb2'])
61+
assert.deepEqual(req.body.checkboxhalfempty, ['cb1', ''])
62+
assert.deepEqual(req.body.checkboxempty, ['', ''])
6463

6564
assert.strictEqual(req.file.fieldname, 'empty')
6665
assert.strictEqual(req.file.originalname, 'empty.dat')
@@ -95,7 +94,7 @@ describe('Memory Storage', function () {
9594
util.submitForm(parser, form, function (err, req) {
9695
assert.ifError(err)
9796

98-
assert(deepEqual(req.body, {}))
97+
assert.deepEqual(req.body, {})
9998

10099
assert.strictEqual(req.files.empty[0].fieldname, 'empty')
101100
assert.strictEqual(req.files.empty[0].originalname, 'empty.dat')

0 commit comments

Comments
 (0)