More theme detection methods?

[goulf-3m]

I guess the current code won't work, if I connect from a light-bg terminal in Windows to a dark-bg Linux machine and launch nvim.

How about more dark/light theme detection methods? Allow users to config, or choose the best suitable one (e.g., do not use local command to detect in a ssh session).

[alexandradeas]

👍 to this. One of the annoyances I've had is using a root shell with nvim and it not detecting the WMs theme settings.

[adityamwagh]

light-bg terminal in Windows to a dark-bg Linux machine

I am not able to understand. How does the Linux machine background matter here?

[f-person]

hi! are u suggesting adding more implementations or adding a way for u to provide your own callback to detect the theme?

[nekowinston]

@alexandradeas

👍 to this. One of the annoyances I've had is using a root shell with nvim and it not detecting the WMs theme settings.

We have some logic that should handle this:

auto-dark-mode.nvim/lua/auto-dark-mode/init.lua

Lines 131 to 145 in 02ef955

	if vim.fn.has("unix") ~= 0 then
	if vim.loop.getuid() == 0 then
	local sudo_user = vim.env.SUDO_USER
	if sudo_user ~= nil then
	query_command = vim.tbl_extend("keep", { "su", "-", sudo_user, "-c" }, query_command)
	else
	error([[
	auto-dark-mode.nvim:
	Running as `root`, but `$SUDO_USER` is not set.
	Please open an issue to add support for your system.
	]])
	end
	end
	end

This should use your non-elevated user id to query the current desktop environment's dark mode.

In general, I'd advise not running neovim as root, especially with plugins, since you're handing root control over to unaudited code, prefer sudo -e when you can.

[nekowinston]

#46 somewhat addresses this, by allowing the user to override how the system appearance is queried.
I'll tackle that PR next after hopefully finally finishing #35 this weekend.

[nekowinston]

Update regarding the running neovim as root situation, I forgot that #35 also fixed an issue there - running nvim as root via sudo, and still having it sync with your system should work now, but I still don't recommend it.

[goulf-3m]

hi! are u suggesting adding more implementations or adding a way for u to provide your own callback to detect the theme?

Exactly!

By the way, the only correct way of automatic bg setting is to infer the background of the active terminal emulator (even a remote one). That might be different from the current OS theme.

[nickhendo]

I am happy to take some feedback on #46 if this is something that people would like :)