D-Bus timeout results in unexpected theme changes

[gwuen]

The query_command for dbus includes a hardcoded timeout of 1000 ms. When it fails because of this, the theme is changed back to the fallback. On a loaded system, this can lead to unexpected theme changes and even flickering if the current system theme is not the same as the fallback and the command only fails every few runs.

My preferred solution would be for (temporary) timeouts to be ignored. Increasing the timeout might do the trick on some systems, on others it might still be too short. Neovim (at least under Linux) correctly sets the background color based on Terminal preference the terminal's response to the OSC 11 query on startup, so there would still be some kind of fallback, even if fetching the preference fails from the start.

The fallback option as it currently is implemented also serves as the fallback for when the system reports no preference (as is the case for GNOME, see #40). If some fallback for failures of the command must remain, it should be something else.

[jakkdl]

+1 on this, I'm getting flickering with the following in the :messages log (from running on the chore/logging branch)

{
  stderr = "",                                                                                 
  stdout = "   variant       variant          uint32 2\n"                                      
}                                                                                              
{                                                                                              
  stderr = "",                                                                                 
  stdout = "   variant       variant          uint32 2\n"                                      
}                                                                                              
{                                                                                              
  stderr = "Error org.freedesktop.DBus.Error.NoReply: Did not receive a reply. Possible causes 
include: the remote application did not send a reply, the message bus security policy blocked t
he reply, the reply timeout expired, or the network connection was broken.\n",                 
  stdout = ""                                                                                  
}      

I have upped the update_interval to 10s, but that did not change things meaningfully.

Though restarting neovim helps, so I should perhaps try to debug why DBus freaks out.

[gwuen]

My last comment on the fallback option seems to be obsolete with #53, as the user can now freely choose between light and dark as fallback without affecting the default behavior on some DEs.

@jakkdl I also find it odd that the dbus query fails, haven't experienced this before. Maybe it's some upstream bug recently introduced?

Nonetheless, I don't think the fallback option should take effect when the query_command fails once or twice, esp. when the colorscheme was already set successfully before.

[ctretyak]