Support custom query_command #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I'm unable to test this against a Windows setup, but I have tested this on both linux and MacOs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been using this project for a long time, but my
i3setup does not setorg.freedesktop.appearance.color-schemeand getting it to has proven trickier than expected. Initially my goal was to add support for the GTK Dark Theme Variant but thought perhaps something more inclusive of any wacky local setup might be better.This PR aims to add an entry point to overwrite the
query_commandwith a custom command, to be matched against thedark_theme_match, which will then toggle the theme accordingly. This is just a first pass, open to any feedback.