Skip to content

Conversation

@fernandoalexandre
Copy link
Contributor

@fernandoalexandre fernandoalexandre commented Jun 14, 2025

Fixed :checkhealth warning (mentioned also in #59 ):
vim.validate is deprecated. Feature will be removed in Nvim 1.0

ADVICE:
    use vim.validate(name, value, validator, optional_or_msg)

instead.
stack traceback:
/home/user/.local/share/nvim/lazy/auto-dark-mode.nvim/lua/auto-dark-mode/init.lua:22
/home/user/.local/share/nvim/lazy/auto-dark-mode.nvim/lua/auto-dark-mode/init.lua:163
/home/user/.local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:387

Fixed :checkhealth warning:
vim.validate is deprecated. Feature will be removed in Nvim 1.0

    ADVICE:
        use vim.validate(name, value, validator, optional_or_msg)
instead.
        stack traceback:
/home/fea/.local/share/nvim/lazy/auto-dark-mode.nvim/lua/auto-dark-mode/init.lua:22
/home/fea/.local/share/nvim/lazy/auto-dark-mode.nvim/lua/auto-dark-mode/init.lua:163
/home/fea/.local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:387
Copy link
Owner

@f-person f-person left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank u!<3

@f-person f-person merged commit 20ea86e into f-person:master Jun 22, 2025
@nekowinston
Copy link
Collaborator

nekowinston commented Jun 22, 2025

Ah, I didn't react to this in time, sorry.
This PR breaks the plugin for neovim 0.10 and older; and we're quite a way from Neovim 1.0.
The tests on main are currently failing, I forgot to have them run on PR branches. @f-person

@fernandoalexandre
Copy link
Contributor Author

fernandoalexandre commented Jun 23, 2025

Ah, I didn't react to this in time, sorry. This PR breaks the plugin for neovim 0.10 and older; and we're quite a way from Neovim 1.0. The tests on main are currently failing, I forgot to have them run on PR branches. @f-person

@f-person @nekowinston Apologies for this impact I'm actually looking into a new PR to make this logic a version-based, apply if it's 0.11 or over, and use the old logic otherwise.

Edit: Created #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants