Merge pull request #2761 from f3d-app/master

3.4 Release Split

Author: mwestphal

.cppcheck.supp

@@ -26,6 +26,7 @@ unknownMacro
 *:*libf3dSDKTests.cxx
 
 // specific checks
+knownConditionTrueFalse:vtkext/private/module/vtkF3DPointSplatMapper.cxx
 knownConditionTrueFalse:library/testing/TestSDKImage.cxx
 knownConditionTrueFalse:library/testing/TestSDKImageDeprecated.cxx
 noExplicitConstructor:library/public/types.h
@@ -38,3 +39,5 @@ invalidPointerCast:plugins/draco/module/vtkF3DGLTFDocumentLoader.cxx
 unusedStructMember:plugins/native/module/vtkF3DQuakeMDLImporter.cxx
 unusedStructMember:plugins/native/module/vtkF3DSPZReader.cxx
 constParameterPointer:vtkext/private/module/vtkF3DMetaImporter.cxx
+constParameterPointer:plugins/assimp/module/vtkF3DAssimpImporter.cxx
+constParameterPointer:plugins/alembic/module/vtkF3DAlembicReader.cxx

.github/ISSUE_TEMPLATE/new_release.md

@@ -15,14 +15,15 @@ Before release:
 
 - [ ] Force fetch origin remote tag with `git fetch origin --tags --force`
 - [ ] Write and format release notes from the pull requests since last release, including contributors and packagers
+- [ ] Create a new [NPM token](https://www.npmjs.com/package/f3d) and replace the existing `NPM_TOKEN` in https://github.com/f3d-app/f3d-superbuild/settings/secrets/actions
 
 Release Split :
 
 - [ ] Create, review and merge a MR from `master` branch into `release`: https://github.com/f3d-app/f3d/compare/release...master
 
 Release Candidates :
 
-- [ ] Commit, review and merge a `vX.Y.Z-RCN` version change in https://github.com/f3d-app/f3d `CMakeLists.txt` and `pyproject.toml` in the `release` branch
+- [ ] Commit, review and merge a `vX.Y.Z-RCN` version change in https://github.com/f3d-app/f3d `CMakeLists.txt`, `pyproject.toml` and `package.json` in the `release` branch
 - [ ] Tag and push to https://github.com/f3d-app/f3d: `git tag vX.Y.Z-RCN -m vX.Y.Z-RCN`
 - [ ] Trigger a release build using https://github.com/f3d-app/f3d-superbuild actions with `vX.Y.Z-RCN` F3D version, superbuild `main` branch and prerelease publish `true`
 - [ ] Download the prerelease from https://github.com/f3d-app/f3d/releases
@@ -33,6 +34,7 @@ Release Candidates :
 - [ ] Locally test the python wheels on Linux
 - [ ] Locally test the python wheels on macOS (Silicon)
 - [ ] Locally test the python wheels on Windows
+- [ ] Locally test the wasm package
 - If it fails,
   - [ ] Fix the issues in `release` branch,
   - [ ] Edit this issue and increment `N`
@@ -41,7 +43,7 @@ Release Candidates :
 
 Release :
 
-- [ ] Commit, review and merge `vX.Y.Z` version change in https://github.com/f3d-app/f3d `CMakeLists.txt`, `pyproject.toml`, `package.json` and the multiple `doxygen\conf.py` in the `release` branch
+- [ ] Commit, review and merge `vX.Y.Z` version change in https://github.com/f3d-app/f3d `CMakeLists.txt`, `pyproject.toml` and `package.json` in the `release` branch
 - [ ] Tag `vX.Y.Z` and push it to https://github.com/f3d-app/f3d: `git tag vX.Y.Z -m vX.Y.Z`
 - [ ] Commit, review and merge adding `X.Y.Z` in https://github.com/f3d-app/f3d-superbuild `versions.cmake` in the `main` branch
 - [ ] Tag `vX.Y.Z` and push it to https://github.com/f3d-app/f3d-superbuild: `git tag vX.Y.Z -m vX.Y.Z`
@@ -51,7 +53,8 @@ Release :
 - [ ] Format the release note into a changelog and commit/review/merge them into https://github.com/f3d-app/f3d
 - [ ] Update dev and nightly docs as described [here](https://f3d.app/dev/TOOLING#how-to-update-the-doc-using-latest-master), commit/review/merge into https://github.com/f3d-app/f3d-website
 - [ ] Add a **new versioned doc** as described [here](https://f3d.app/dev/TOOLING#how-to-update-the-doc-for-a-new-release), commit/review/merge into https://github.com/f3d-app/f3d-website
-- [ ] Update **download links** using `GITHUB_TOKEN=$PAT npm run update-downloads`, commit/review/merge into https://github.com/f3d-app/f3d-website
+- [ ] Commit review and merge a bump of F3D version in `package.json` in https://github.com/f3d-app/f3d-website
+- [ ] Update **download links** using `GITHUB_TOKEN=$PAT npm run update-downloads`, commit/review/merge into https://github.com/f3d-app/f3d-website and then immediately
 - [ ] Release
 - [ ] Communicate on discord
 - [ ] Communicate on reddit
@@ -131,6 +134,18 @@ eng.interactor.start()
   - The name of the window is `f3d` at all time
   - Python provides suggestions whenever the "Tab" key is pressed
 
+Webassembly testing protocol:
+
+- Clone https://github.com/f3d-app/f3d-website
+- Replace the current `f3d` version by the last RC available and run the website locally to check the web viewer
+- Make sure to check for broken anchor in the npm output
+
+```bash
+npm uninstall f3d
+npm install f3d --tag next
+npm run start
+```
+
 Once a release cycle:
 
 - Check that completions are still working with `fish` and `zsh` when tab is pressed

.github/PULL_REQUEST_TEMPLATE.md

@@ -8,7 +8,7 @@
 - [ ] I have added [tests](https://f3d.app/dev/TESTING) for new features and bugfixes
 - [ ] I have added [documentation](https://f3d.app/docs/next/user/QUICKSTART) for new features
 - [ ] If it is a modifying the libf3d API, I have updated bindings
-- [ ] If it is a modifying the `.github/workflows/versions.json`, I have updated `timestamp`
+- [ ] If it is a modifying the `.github/workflows/versions.json`, I have updated `docker_timestamp`
 
 ### Continuous integration
 

.github/actions/alembic-install-dep/action.yml

@@ -11,6 +11,9 @@ inputs:
   imath_version:
     description: "Version of imath to build against"
     required: true
+  global_cache_index:
+    description: "Global cache index"
+    required: true
 
 runs:
   using: "composite"
@@ -20,13 +23,14 @@ runs:
       run: |
         [[ "${{ inputs.version }}" ]] || { echo "version input is empty" ; exit 1; }
         [[ "${{ inputs.imath_version }}" ]] || { echo "imath_version input is empty" ; exit 1; }
+        [[ "${{ inputs.global_cache_index }}" ]] || { echo "global_cache_index input is empty" ; exit 1; }
 
     - name: Cache Alembic
       id: cache-alembic
       uses: actions/cache/restore@v4
       with:
         path: dependencies/alembic_install
-        key: alembic-${{inputs.version}}-${{inputs.imath_version}}-${{runner.os}}-${{inputs.cpu}}-1
+        key: alembic-${{inputs.version}}-${{inputs.imath_version}}-${{runner.os}}-${{inputs.cpu}}-${{inputs.global_cache_index}}-3
 
     - name: Checkout Alembic
       if: steps.cache-alembic.outputs.cache-hit != 'true'
@@ -36,6 +40,13 @@ runs:
         path: "./dependencies/alembic"
         ref: ${{inputs.version}}
 
+    # https://github.com/alembic/alembic/issues/476
+    - name: Patch Alembic rpath issue
+      if: steps.cache-alembic.outputs.cache-hit != 'true' && inputs.version == '1.8.9'
+      working-directory: ${{github.workspace}}/dependencies/alembic
+      shell: bash
+      run: patch -p1 < $GITHUB_ACTION_PATH/fix_cmake_rpath.patch
+
     - name: Setup Alembic
       if: steps.cache-alembic.outputs.cache-hit != 'true'
       working-directory: ${{github.workspace}}/dependencies

.github/actions/alembic-install-dep/fix_cmake_rpath.patch

@@ -0,0 +1,26 @@
+From 99caa8156fb65a1c0a97ef4b168ca720787e04b8 Mon Sep 17 00:00:00 2001
+From: Mathieu Westphal <[email protected]>
+Date: Thu, 30 Oct 2025 08:49:47 +0100
+Subject: [PATCH] fix_cmake_rpath
+
+---
+ lib/Alembic/CMakeLists.txt | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/lib/Alembic/CMakeLists.txt b/lib/Alembic/CMakeLists.txt
+index 8cb8ddb9..b5a73a6d 100644
+--- a/lib/Alembic/CMakeLists.txt
++++ b/lib/Alembic/CMakeLists.txt
+@@ -67,6 +67,9 @@ IF (ALEMBIC_SHARED_LIBS)
+     VERSION ${PROJECT_VERSION})
+ ENDIF()
+ 
++if (APPLE OR UNIX)
++  set_target_properties(Alembic PROPERTIES INSTALL_RPATH "$<TARGET_FILE_DIR:Imath::Imath>")
++endif ()
+ 
+ TARGET_LINK_LIBRARIES(Alembic
+     LINK_PUBLIC
+-- 
+2.51.1
+

.github/actions/assimp-install-dep/action.yml

@@ -8,6 +8,9 @@ inputs:
   version:
     description: "Version of assimp to build"
     required: true
+  global_cache_index:
+    description: "Global cache index"
+    required: true
 
 runs:
   using: "composite"
@@ -16,13 +19,14 @@ runs:
       shell: bash
       run: |
         [[ "${{ inputs.version }}" ]] || { echo "version input is empty" ; exit 1; }
+        [[ "${{ inputs.global_cache_index }}" ]] || { echo "global_cache_index input is empty" ; exit 1; }
 
     - name: Cache ASSIMP
       id: cache-assimp
       uses: actions/cache/restore@v4
       with:
         path: dependencies/assimp_install
-        key: assimp-${{inputs.version}}-${{runner.os}}-${{inputs.cpu}}-1
+        key: assimp-${{inputs.version}}-${{runner.os}}-${{inputs.cpu}}-${{inputs.global_cache_index}}-1
 
     - name: Checkout ASSIMP
       if: steps.cache-assimp.outputs.cache-hit != 'true'

.github/actions/blosc-install-dep/action.yml

@@ -11,6 +11,9 @@ inputs:
   zlib_version:
     description: "Version of zlib to build against"
     required: true
+  global_cache_index:
+    description: "Global cache index"
+    required: true
 
 runs:
   using: "composite"
@@ -20,13 +23,14 @@ runs:
       run: |
         [[ "${{ inputs.version }}" ]] || { echo "version input is empty" ; exit 1; }
         [[ "${{ inputs.zlib_version }}" ]] || { echo "zlib_version input is empty" ; exit 1; }
+        [[ "${{ inputs.global_cache_index }}" ]] || { echo "global_cache_index input is empty" ; exit 1; }
 
     - name: Cache blosc
       id: cache-blosc
       uses: actions/cache/restore@v4
       with:
         path: dependencies/blosc_install
-        key: blosc-${{inputs.version}}-${{inputs.zlib_version}}-${{runner.os}}-${{inputs.cpu}}-1
+        key: blosc-${{inputs.version}}-${{inputs.zlib_version}}-${{runner.os}}-${{inputs.cpu}}-${{inputs.global_cache_index}}-1
 
     # Dependents: openvdb vtk
     - name: Checkout blosc

.github/actions/coverage-ci/action.yml

@@ -50,6 +50,9 @@ inputs:
   zlib_version:
     description: "Version of zlib to build"
     required: true
+  global_cache_index:
+    description: "Global cache index"
+    required: true
 
 runs:
   using: "composite"
@@ -61,7 +64,7 @@ runs:
         [[ "${{ inputs.vtk_version }}" ]] || { echo "vtk_version input is empty" ; exit 1; }
 
     - name: Recover LFS Data
-      uses: f3d-app/lfs-data-cache-action@v1
+      uses: f3d-app/lfs-data-cache-action@v2
       with:
         type: "consumer"
         lfs_sha: ${{inputs.lfs_sha}}
@@ -83,6 +86,7 @@ runs:
         usd_version: ${{inputs.usd_version}}
         webp_version: ${{inputs.webp_version}}
         zlib_version: ${{inputs.zlib_version}}
+        global_cache_index: ${{inputs.global_cache_index}}
 
     - name: Install VTK dependency
       uses: ./source/.github/actions/vtk-install-dep
@@ -93,6 +97,7 @@ runs:
         tbb_version: ${{inputs.tbb_version}}
         vtk_version: ${{inputs.vtk_version}}
         zlib_version: ${{inputs.zlib_version}}
+        global_cache_index: ${{inputs.global_cache_index}}
 
     # coverage build is done in source as it seems to be required for codecov
     # CMAKE_MODULE_PATH is required because of

.github/actions/draco-install-dep/action.yml

@@ -8,6 +8,9 @@ inputs:
   version:
     description: "Version of draco to build"
     required: true
+  global_cache_index:
+    description: "Global cache index"
+    required: true
 
 runs:
   using: "composite"
@@ -16,13 +19,14 @@ runs:
       shell: bash
       run: |
         [[ "${{ inputs.version }}" ]] || { echo "version input is empty" ; exit 1; }
+        [[ "${{ inputs.global_cache_index }}" ]] || { echo "global_cache_index input is empty" ; exit 1; }
 
     - name: Cache Draco
       id: cache-draco
       uses: actions/cache/restore@v4
       with:
         path: dependencies/draco_install
-        key: draco-${{inputs.version}}-${{runner.os}}-${{inputs.cpu}}-4
+        key: draco-${{inputs.version}}-${{runner.os}}-${{inputs.cpu}}-${{inputs.global_cache_index}}-0
 
     - name: Checkout Draco
       if: steps.cache-draco.outputs.cache-hit != 'true'

.github/actions/external-build-ci/action.yml

@@ -13,6 +13,9 @@ inputs:
   zlib_version:
     description: "Version of zlib to build"
     required: true
+  global_cache_index:
+    description: "Global cache index"
+    required: true
 
 runs:
   using: "composite"
@@ -42,6 +45,7 @@ runs:
         blosc_version: ${{inputs.blosc_version}}
         tbb_version: ${{inputs.tbb_version}}
         zlib_version: ${{inputs.zlib_version}}
+        global_cache_index: ${{inputs.global_cache_index}}
 
     - name: Install VTK dependency
       uses: ./source/f3d/.github/actions/vtk-install-dep
@@ -50,6 +54,7 @@ runs:
         tbb_version: ${{inputs.tbb_version}}
         vtk_version: ${{inputs.vtk_version}}
         zlib_version: ${{inputs.zlib_version}}
+        global_cache_index: ${{inputs.global_cache_index}}
 
     - name: Setup Build Directory
       shell: bash