Print config info

[atharvRsharma]

Tried to continue nanononi's implementation, might not be what was asked of me. The seperation of concerns approach was used where ReadConfigFiles is left alone to actually apply the config file if found, as of now the configpath func finds all possible paths and returns a vector of them, printconfiginfo then checks existence of files within said path then give output to the console.

#2349

[mwestphal]

First lets "just" rebase naninoni work, so the diff looks similar to this: https://github.com/f3d-app/f3d/pull/2382/files

[mwestphal]

Need any help moving forward @atharvRsharma ?

[atharvRsharma]

oh my bad, shouldve kept you updated, as of right now no i dont need help as id like to figure this out on my own but i will definitely ask if im stuck

[mwestphal]

changes needed

[atharvRsharma]

should i push the updated version with the changes you specified with/without rebasing or do i just continue with the implementation for now and push when ive done a substantial amount of work?

[mwestphal]

Hi @atharvRsharma

Need any help moving forward ?

[atharvRsharma]

Hi @atharvRsharma

Need any help moving forward ?

Sorry, exams coming up, I'm still trying obviously, it'll just be a little slower, hope that's not a problem

[mwestphal]

No problem, thanks for the feedback :)

[mwestphal]

Hi @atharvRsharma

Need any help moving forward ?

[atharvRsharma]

Hi @atharvRsharma

Need any help moving forward ?

Hi, yea I'm so sorry, I think it's best if you unassign me for now, I'll be free from the 23rd when my exams end and if the issue is still free I'll ask to be assigned then, I don't want to block any other people from working on this issue obviously.

[mwestphal]

No worries, this can wait for january :)

[atharvRsharma]

thank you so much for understanding.

[mwestphal]

Hi @atharvRsharma

Let me know when this is ready for review :)

[atharvRsharma]

Hi @atharvRsharma

Let me know when this is ready for review :)

Hi yea, it should be ready now, accidentally commented an else block i wasnt supposed to, should be fine hopefully.

[mwestphal]

This seems correct to me, small nitpicking changes.

I'll run CI.

@snoyer please review

[mwestphal]

\ci fast

[mwestphal]

please rebase on latest master @atharvRsharma

[atharvRsharma]

yes of course ill get on that as soon as possible, does the main implementation seem fine? aside from the few style changes you suggested and the noexcept part

[mwestphal]

I’m not entirely sure why the patch coverage check is failing again, is it expected of me to write tests for the print_config_info func? seems a little adhoc-y but then again i dont really know how patch coverage works

Dont worry about it, Ill check it out.

[atharvRsharma]

thank you

[mwestphal]

Too increase coverage you should be able to add a "TooLong" test for --config, see application/testing/CMakeLists.txt 1680.

[atharvRsharma]

Too increase coverage you should be able to add a "TooLong" test for --config, see application/testing/CMakeLists.txt 1680.

f3d_test(NAME TestTooLongConfigCLI ARGS --config config NO_RENDER NO_BASELINE LONG_TIMEOUT) does this work? should i add a comment for this?

[mwestphal]

Too increase coverage you should be able to add a "TooLong" test for --config, see application/testing/CMakeLists.txt 1680.

f3d_test(NAME TestTooLongConfigCLI ARGS --config config NO_RENDER NO_BASELINE LONG_TIMEOUT) does this work? should i add a comment for this?

You definitely need a REGEX of some sort

[atharvRsharma]

could you maybe explain what the regex means and does in this context? im not really aware about the concept, sorry by the way.

[mwestphal]

could you maybe explain what the regex means and does in this context? im not really aware about the concept, sorry by the way.

A REGEX test would read the textual output of F3D and check a specific string is present in the output.

[atharvRsharma]

ohhh, ok i get it, i have this thats supposed to execute regardless of config file existence(this just checks path existence)

{
  f3d::log::info("Found available config path");
}```

so should it be something like 
```f3d_test(NAME TestTooLongConfigCLI ARGS --config config NO_RENDER NO_BASELINE LONG_TIMEOUT PASS_REGULAR_EXPRESSION "Found available config path")``` ?

[mwestphal]

ohhh, ok i get it, i have this thats supposed to execute regardless of config file existence(this just checks path existence)

{
  f3d::log::info("Found available config path");
}```

so should it be something like 
```f3d_test(NAME TestTooLongConfigCLI ARGS --config config NO_RENDER NO_BASELINE LONG_TIMEOUT PASS_REGULAR_EXPRESSION "Found available config path")``` ?

Not really no, can we discuss on discord ?

[atharvRsharma]

ohhh, ok i get it, i have this thats supposed to execute regardless of config file existence(this just checks path existence)

{
  f3d::log::info("Found available config path");
}```

so should it be something like 
```f3d_test(NAME TestTooLongConfigCLI ARGS --config config NO_RENDER NO_BASELINE LONG_TIMEOUT PASS_REGULAR_EXPRESSION "Found available config path")``` ?

Not really no, can we discuss on discord ?

yes of course 1 sec

[mwestphal]

small changes needed

[atharvRsharma]

Understood

[atharvRsharma]

apologies for the double commits, network went down and it didnt show the account selection popup so i thought it failed

[mwestphal]

small changes

[atharvRsharma]

anything left for me to do? is rebasing necessary yet?

[mwestphal]

@snoyer please review :)

[mwestphal]

anything left for me to do? is rebasing necessary yet?

lets just give a chance for @snoyer to review :)

[atharvRsharma]

anything left for me to do? is rebasing necessary yet?

lets just give a chance for @snoyer to review :)

of course, also may i ask an off-issue question?

[mwestphal]

also may i ask an off-issue question?

Sure, but maybe on discord ? :)

[mwestphal]

No feedback from @snoyer , merging :)