Skip to content

Conversation

@noclone
Copy link
Contributor

@noclone noclone commented Jan 6, 2026

Describe your changes

Add support for saving multiple frames when using animation with --output and frame template filename

Issue ticket number and link if any

#46

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@noclone
Copy link
Contributor Author

noclone commented Jan 6, 2026

\ci fast

@noclone
Copy link
Contributor Author

noclone commented Jan 6, 2026

\ci full

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.65%. Comparing base (6c5c9a0) to head (1afa9ee).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2785      +/-   ##
==========================================
+ Coverage   96.64%   96.65%   +0.01%     
==========================================
  Files         142      142              
  Lines       12918    12960      +42     
==========================================
+ Hits        12484    12526      +42     
  Misses        434      434              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@noclone noclone force-pushed the multi-frames-output branch from 765b866 to dbe49c3 Compare January 6, 2026 19:29
@Meakk
Copy link
Member

Meakk commented Jan 6, 2026

Looks quite good! How does it behave with --animation-time?

@noclone
Copy link
Contributor Author

noclone commented Jan 6, 2026

Looks quite good! How does it behave with --animation-time?

I'm pretty sure it's overriden for now, so animation time is ignored. What would be the expected behavior ?

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions

@mwestphal
Copy link
Member

Definitely needs a @snoyer review

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs a doc update and a @snoyer review :)

@mwestphal mwestphal requested a review from snoyer January 7, 2026 20:49
Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small doc change again

@noclone noclone force-pushed the multi-frames-output branch from b7a4252 to 974b6b1 Compare January 8, 2026 08:43
Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestion, @snoyer please review

Co-authored-by: Mathieu Westphal <[email protected]>
@noclone noclone force-pushed the multi-frames-output branch from 3fd0469 to b66688b Compare January 8, 2026 16:55
Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a test missing for full coverage

@noclone noclone force-pushed the multi-frames-output branch from 229c634 to 0f27291 Compare January 8, 2026 19:22
@mwestphal
Copy link
Member

lets just for a last @snoyer review :)

Copy link
Contributor

@snoyer snoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the Discord thread, I still feel like the code paths are more complex than they need to be but I haven't had time to sit down and see if they can be untangled.
Otherwise it looks like it work and the UI is good from what I can tell so we can always refactor and optimize later.

@noclone
Copy link
Contributor Author

noclone commented Jan 9, 2026

all suggestions applied

@mwestphal mwestphal merged commit 2dbe547 into f3d-app:master Jan 10, 2026
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants