Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plural rules are not updated when setLanguage() executed #77

Open
OleksandrSemenov opened this issue Feb 18, 2016 · 1 comment
Open

Comments

@OleksandrSemenov
Copy link

Subj.
Error is here:
...
// initialize _pluralRules
if (!gMacros._pluralRules) {
gMacros._pluralRules = getPluralRules(gLanguage);
}
...
so, pluralRules are intializaed only once.
To fix it, remove if statement:
...
// initialize _pluralRules
gMacros._pluralRules = getPluralRules(gLanguage);
...

@Rob--W
Copy link
Collaborator

Rob--W commented Feb 19, 2016

Patches are welcome. The proper fix is not to unconditionally call getPluralRules, but call getPluralRules again in setLanguage if the language changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants