Skip to content

seperate_words function based on \W+ re instead? #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jkterry1 opened this issue Aug 8, 2017 · 5 comments · Fixed by #26
Closed

seperate_words function based on \W+ re instead? #23

jkterry1 opened this issue Aug 8, 2017 · 5 comments · Fixed by #26
Labels
question

Comments

@jkterry1
Copy link
Collaborator

jkterry1 commented Aug 8, 2017

@fabianvf Is it my imagination or could we replace the entire separate_words function better with a \W+ or \W regex instead?
@jkterry1
Copy link
Collaborator Author

@fabianvf bump

@jkterry1
Copy link
Collaborator Author

@fabianvf thoughts on this?

@fabianvf
Copy link
Owner

Honestly I'm not sure, does it make a difference? Wonder if there are any edge cases related to punctuation or something that will bite us.

@jkterry1
Copy link
Collaborator Author

jkterry1 commented Aug 31, 2017 via email

@jkterry1
Copy link
Collaborator Author

@fabianvf Also doing it that way is faster, easier to understand and more maintainable/pythonic

@jkterry1 jkterry1 mentioned this issue Sep 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add config operators
2 participants
@fabianvf @jkterry1