Skip to content

Extension breaks when using SSH alias in latest version #37

@SiarheiBokuts

Description

@SiarheiBokuts

Hi!

I found that this extension stops working when using an SSH alias.

My setup:

SSH alias: github.com-personal
Origin: [email protected]:SiarheiBokuts/NestJS-playground.git

It works fine in version 2.1.3 — “Open in GitHub” navigates to the correct URL:
https://github.com/SiarheiBokuts/NestJS-playground

But in version 2.3.1 (latest), it generates the wrong URL:
https://github.com/-personal:SiarheiBokuts/NestJS-playground

As you can see, the -personal part from the alias is not removed correctly.

Here’s the list of changes between these two versions:
v2.1.3...master

I believe the relevant change might be related to the regexp.

Could you please check this and consider improving the regexp to handle SSH aliases properly?

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions