Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review for Georgia, Derek and Dominic S. #6

Open
konstantinakatmada opened this issue Nov 15, 2022 · 0 comments
Open

Code review for Georgia, Derek and Dominic S. #6

konstantinakatmada opened this issue Nov 15, 2022 · 0 comments

Comments

@konstantinakatmada
Copy link

@konstantinakatmada
Also available at the repo:
https://github.com/fac26 /
todo-derek-dominicS-georgia

general code review #10

konstantinakatmada commented Nov 8, 2022
README

####Does the README fully describe the project?

Yes, nice work done
User stories

####Does the project meet the user stories for that week?

User stories and project seem to make sense perfectly when read in tamdem.
Learning outcomes

####Does it demonstrate the learning outcomes for that week?

This is a 2 week, rather than a weekly, project, and the learning outcomes are very advanced.
UI bugs

[Can you see any obvious bugs or areas to improve?]

No, the form has some features that are already deployed (at the javascript-functionality branch) and they work with no bugs.
Instructions

####Does everything work as expected or were there missing instructions?

Everything works as expected.
File structure

####When you open the project in your editor, does the file structure make sense?

Yes, I like the way the organised this.
Flow of control
Can you you follow the different paths the code might take?

I believe so, to my understanding it is pretty neat.
Naming

####Do variables and functions have clear and descriptive names?

Yes, the names given really help.
Readability

####Do you understand the code?

I believe so. There are always going to be uses of code that one has never seen, which is an awesome learning opportunity.
@konstantinakatmada

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant