Skip to content

general code review #10

Open
Open
@konstantinakatmada

Description

@konstantinakatmada

README

####Does the README fully describe the project?

Yes, nice work done

User stories

####Does the project meet the user stories for that week?

User stories and project seem to make sense perfectly when read in tamdem.

Learning outcomes

####Does it demonstrate the learning outcomes for that week?

This is a 2 week, rather than a weekly, project, and the learning outcomes are very advanced.

UI bugs

[Can you see any obvious bugs or areas to improve?]

No, the form has some features that are already deployed (at the javascript-functionality branch) and they work with no bugs.

Instructions

####Does everything work as expected or were there missing instructions?

Everything works as expected.

File structure

####When you open the project in your editor, does the file structure make sense?

Yes, I like the way the organised this.

Flow of control

Can you you follow the different paths the code might take?

I believe so, to my understanding it is pretty neat.

Naming

####Do variables and functions have clear and descriptive names?

Yes, the names given really help.

Readability

####Do you understand the code?

I believe so. There are always going to be uses of code that one has never seen, which is an awesome learning opportunity.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions